From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S934449AbbEOIrR (ORCPT <rfc822;w@1wt.eu>);
	Fri, 15 May 2015 04:47:17 -0400
Received: from mail-wg0-f49.google.com ([74.125.82.49]:35454 "EHLO
	mail-wg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S934031AbbEOIrO (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 15 May 2015 04:47:14 -0400
Message-ID: <5555B28A.9040608@linaro.org>
Date: Fri, 15 May 2015 09:47:06 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Patrick Lai <plai@codeaurora.org>, Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v1 11/13] ASoC: qcom: add apq8016 sound card support
References: <1431518302-7139-1-git-send-email-srinivas.kandagatla@linaro.org> <1431518594-7752-1-git-send-email-srinivas.kandagatla@linaro.org> <20150515052348.GC31687@kwestfie-linux.qualcomm.com>
In-Reply-To: <20150515052348.GC31687@kwestfie-linux.qualcomm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 15/05/15 06:23, Kenneth Westfield wrote:
> On Wed, May 13, 2015 at 05:03:14AM -0700, Srinivas Kandagatla wrote:
>> This patch adds apq8016 machine driver support. This patch was tested on
>> two apq8016-sbc and msm8916-mtp board for both hdmi and analog audio
>> features.
>
>> diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig
>> index 9cc5ed7..e71b0f2 100644
>> --- a/sound/soc/qcom/Kconfig
>> +++ b/sound/soc/qcom/Kconfig
>> @@ -34,3 +34,12 @@ config SND_SOC_STORM
>>   	help
>>             Say Y or M if you want add support for SoC audio on the
>>             Qualcomm Technologies IPQ806X-based Storm board.
>> +
>> +config SND_SOC_APQ8016_SBC
>> +	tristate "SoC Audio support for APQ8016 SBC platforms"
>> +	depends on SND_SOC_QCOM || ARCH_QCOM || COMPILE_TEST
>
> I believe this should be:
>          depends on (SND_SOC_QCOM && ARCH_QCOM) || COMPILE_TEST
>
Yep , I will fix it.
>> +	select SND_SOC_LPASS_APQ8016
>> +	help
>> +          Support for Qualcomm Technologies LPASS audio block in
>> +          APQ8016 SOC-based systems.
>> +          Say Y if you want to use audio devices on MI2S
>