Re: [RFC PATCH v2 00/37] perf tools: introduce 'perf bpf' command to load eBPF programs.

["Wangnan (F)" <wangnan0@huawei.com>]

在 2015/5/15 16:48, Ingo Molnar 写道:
> * Wangnan (F) <wangnan0@huawei.com> wrote:
>
>>    perf tools: Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit
>>    tools lib traceevent: Install libtraceevent.a into libdir
>>    tools: Allow other override features to check
> Hm, to check what? Not sure I can parse this sentence at a glance.

Changed to:

   tools: Change FEATURE_TESTS and FEATURE_DISPLAY to weak binding

>>    tools: Add __aligned_u64 to types.h
>>    tools lib bpf: Introduce 'bpf' library to tools
>>    tools lib bpf: Allow set printing function
>>    tools lib bpf: Define basic interface
> So you changed 'tools perf' to 'perf tools', but you should probably
> find a better name for 'tools lib bpf' as well, say:
>
>      bpf tools: Define basic interface
>
> ?

The style is copied from lib traceevent. I'll change it as your suggestion.

[..]

Thanks a lot. I changed titles again:

   tools lib traceevent: Install libtraceevent.a into libdir
   tools: Change FEATURE_TESTS and FEATURE_DISPLAY to weak binding
   tools: Add __aligned_u64 to types.h
   bpf tools: Introduce 'bpf' library to tools
   bpf tools: Allow caller to set printing function
   bpf tools: Define basic interface
   bpf tools: Open eBPF object file and do basic validation
   bpf tools: Check endianess and set swap flag according to EHDR
   bpf tools: Iterate over ELF sections to collect information
   bpf tools: Collect version and license from ELF sections
   bpf tools: Collect map definitions from 'maps' section
   bpf tools: Collect config string from 'config' section
   bpf tools: Collect symbol table from SHT_SYMTAB section
   bpf tools: Collect eBPF programs from their own sections
   bpf tools: Collect relocation sections from SHT_REL sections
   bpf tools: Record map accessing instructions for each program
   bpf tools: Clear libelf and ELF parsing resrouce to finish opening
   bpf tools: Add bpf.c/h for common bpf operations
   bpf tools: Create eBPF maps defined in an object file
   bpf tools: Relocate eBPF programs
   bpf tools: Introduce bpf_load_program() to bpf.c
   bpf tools: Load eBPF programs in object files into kernel
   bpf tools: Introduce accessors for struct bpf_program
   bpf tools: Introduce accessors for struct bpf_object
   perf tools: Add new 'perf bpf' command
   perf tools: Make perf depend on libbpf
   perf bpf: Add 'perf bpf record' subcommand
   perf bpf: Add bpf-loader and open ELF object files
   perf bpf: Collect all eBPF programs
   perf bpf: Parse probe points of eBPF programs during preparation
   perf bpf: Probe at kprobe points
   perf bpf: Load all eBPF object into kernel
   perf tools: Add a bpf_wrapper global flag
   perf tools: Add bpf_fd field to evsel and introduce new event syntax
   perf bpf: Generate event argv for other commands
   perf bpf: Pass generated arguments to cmd_record()

Do you have further suggestion?

Thank you.