From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933827AbbEOKTI (ORCPT ); Fri, 15 May 2015 06:19:08 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:58563 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754719AbbEOKTD (ORCPT ); Fri, 15 May 2015 06:19:03 -0400 X-AuditID: cbfee691-f79ca6d00000456a-ec-5555c8157034 Message-id: <5555C814.7030405@samsung.com> Date: Fri, 15 May 2015 19:19:00 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Dan Carpenter Cc: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [patch] regulator: max77686: fix a shift wrapping bug References: <20150515092501.GB21508@mwanda> In-reply-to: <20150515092501.GB21508@mwanda> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsWyRsSkUFf0RGiowawWCYupD5+wWbz+N53F 4vULQ4utt6Qtvl3pYLK4vGsOmwObx85Zd9k9Nq3qZPP4+PQWi0ffllWMHp83yQWwRnHZpKTm ZJalFunbJXBlPOrpZi5YwFVxcuYZ1gbG5RxdjJwcEgImEq92/meCsMUkLtxbzwZiCwksZZT4 uMUBpubO4k3sXYxcQPFFjBKPrsxhgih6wCjx5ZsBiM0roCXxcWo3WDOLgKrE+jUd7CA2G1B8 /4sbYHFRgTCJldOvsEDUC0r8mHwPzBYR0JG43PkDbAGzwC5GiZ+rToAtEBZwktgy5xkjxDJt iQlfr4PFOYEaDnUuABvKDGTvb50GZctLbF7zlhlkkITAPnaJHZOfMkNcJCDxbfIhoG0cQAlZ iU0HmCE+k5Q4uOIGywRGsVlIbpqFZOwsJGMXMDKvYhRNLUguKE5KLzLVK07MLS7NS9dLzs/d xAiMtNP/nk3cwXj/gPUhRgEORiUe3gSH0FAh1sSy4srcQ4ymQFdMZJYSTc4HxnNeSbyhsZmR hamJqbGRuaWZkjivjvTPYCGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2MdTNqzAv/+sw7dofj QNyyU6l/21f3O8zX7l7Kv+Mo24xn8V9CP77NSWrRKOTliog5Zjn19O4pCzVvCatOkWZXfv/C ZObXguXf4grfVR1haYnz8zzzafq7drN7kbsO20jtfNi6tfKf8MTsDQ3fS/7Xb5+7V4FRusVz LbtORWGZ+gXXyh1Vq98/VWIpzkg01GIuKk4EAH+K18yvAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrOIsWRmVeSWpSXmKPExsVy+t9jAV3RE6GhBp9mCltMffiEzeL1v+ks Fq9fGFpsvSVt8e1KB5PF5V1z2BzYPHbOusvusWlVJ5vHx6e3WDz6tqxi9Pi8SS6ANaqB0SYj NTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6AAlhbLEnFKg UEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8ajnm7mggVcFSdnnmFtYFzO0cXIySEh YCJxZ/EmdghbTOLCvfVsXYxcHEICixglHl2ZwwSSEBJ4wCjx5ZsBiM0roCXxcWo3G4jNIqAq sX5NB1gzG1B8/4sbYHFRgTCJldOvsEDUC0r8mHwPzBYR0JG43PmDHWQBs8AuRomfq06ALRAW cJLYMucZI8QybYkJX6+DxTmBGg51LgAbygxk72+dBmXLS2xe85Z5AqPALCQ7ZiEpm4WkbAEj 8ypG0dSC5ILipPRcQ73ixNzi0rx0veT83E2M4Eh+JrWDcWWDxSFGAQ5GJR7eRIfQUCHWxLLi ytxDjBIczEoivPpbgUK8KYmVValF+fFFpTmpxYcYTYFBMJFZSjQ5H5hk8kriDY1NzIwsjcwN LYyMzZXEeU/m+4QKCaQnlqRmp6YWpBbB9DFxcEo1MGrlv0qfqW8Rf+W8zq81OVqf7mt8Nz/7 Yda9swL7dq+qFDtfeCvjytUjWWriU14meXE+aZiyqvJMpYquzuGyIB53oztHNjLd+rwp8uUK uWsWU6wup50MUHrDey15s/rExONb77Xsi2zoF1Ce+chDKFzWqS7YUNTgBP+tc1OCDY6oXv1z I+Zs9T8lluKMREMt5qLiRAB7cUdB+gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dan, On 05/15/2015 06:25 PM, Dan Carpenter wrote: > We need to be able to handle more than 32 bits here because "id" can go > up to MAX77686_BUCK9 (34). ->gpio_enabled is a u64 so that's fine > already. > > Fixes: 3307e9025d29 ('regulator: max77686: Add GPIO control') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/regulator/max77686.c b/drivers/regulator/max77686.c > index 23b7c06..59b3210 100644 > --- a/drivers/regulator/max77686.c > +++ b/drivers/regulator/max77686.c > @@ -121,7 +121,7 @@ static unsigned int max77686_map_normal_mode(struct max77686_data *max77686, > case MAX77686_BUCK8: > case MAX77686_BUCK9: > case MAX77686_LDO20 ... MAX77686_LDO22: > - if (max77686->gpio_enabled & (1 << id)) > + if (max77686->gpio_enabled & (1ULL << id)) > return MAX77686_GPIO_CONTROL; > } > > @@ -277,7 +277,7 @@ static int max77686_of_parse_cb(struct device_node *np, > } > > if (gpio_is_valid(config->ena_gpio)) { > - max77686->gpio_enabled |= (1 << desc->id); > + max77686->gpio_enabled |= (1ULL << desc->id); > > return regmap_update_bits(config->regmap, desc->enable_reg, > desc->enable_mask, > Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi