linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Bob Liu <bob.liu@oracle.com>
Cc: <xen-devel@lists.xen.org>, <david.vrabel@citrix.com>,
	<justing@spectralogic.com>, <konrad.wilk@oracle.com>,
	<paul.durrant@citrix.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place
Date: Fri, 15 May 2015 13:14:00 +0200	[thread overview]
Message-ID: <5555D4F8.40701@citrix.com> (raw)
In-Reply-To: <5555D26B.8040002@oracle.com>

El 15/05/15 a les 13.03, Bob Liu ha escrit:
> 
> On 05/15/2015 06:01 PM, Roger Pau Monné wrote:
>> El 12/05/15 a les 13.01, Bob Liu ha escrit:
>>> The right place for talk_to_blkback() to query backend features and transport
>>> parameters is after backend entered XenbusStateInitWait. There is no problem
>>
>> talk_to_blkback doesn't gather any backend features, it just publishes
>> the features supported by the frontend, which AFAICT can be done at any
> 
> 1) But talk_tlkback will also allocate and initialize the request ring which
> should be done after backend entered XenbusStateInitWait.

Maybe setup_blkring should be moved to a more suitable location instead
of moving the whole function?

Roger.


  reply	other threads:[~2015-05-15 11:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-12 11:01 [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place Bob Liu
2015-05-12 11:01 ` [PATCH v3 2/2] xen/block: add multi-page ring support Bob Liu
2015-05-15 11:13   ` Roger Pau Monné
2015-05-15 12:06     ` Bob Liu
2015-05-20  9:34       ` Roger Pau Monné
2015-05-15 10:01 ` [PATCH 1/2] driver: xen-blkfront: move talk_to_blkback to the correct place Roger Pau Monné
2015-05-15 11:03   ` Bob Liu
2015-05-15 11:14     ` Roger Pau Monné [this message]
2015-05-15 11:35       ` Bob Liu
2015-05-15 11:57         ` Roger Pau Monné

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5555D4F8.40701@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=bob.liu@oracle.com \
    --cc=david.vrabel@citrix.com \
    --cc=justing@spectralogic.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paul.durrant@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).