From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946090AbbEOVAW (ORCPT ); Fri, 15 May 2015 17:00:22 -0400 Received: from mail-bl2on0092.outbound.protection.outlook.com ([65.55.169.92]:14765 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934201AbbEOVAO (ORCPT ); Fri, 15 May 2015 17:00:14 -0400 X-Greylist: delayed 169885 seconds by postgrey-1.27 at vger.kernel.org; Fri, 15 May 2015 17:00:14 EDT Authentication-Results: spf=fail (sender IP is 66.35.236.227) smtp.mailfrom=opensource.altera.com; kernel.org; dkim=none (message not signed) header.d=none; Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none; Message-ID: <55565EB3.7040102@opensource.altera.com> Date: Fri, 15 May 2015 16:01:39 -0500 From: Thor Thayer Reply-To: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Arnd Bergmann , CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 4/4] dts, altera: Arria10 SDRAM EDAC DTS additions. References: <1431553787-27741-1-git-send-email-tthayer@opensource.altera.com> <1431553787-27741-5-git-send-email-tthayer@opensource.altera.com> <5383549.sAl5szqT14@wuerfel> In-Reply-To: <5383549.sAl5szqT14@wuerfel> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: SN1PR0701CA0021.namprd07.prod.outlook.com (25.162.96.31) To DM2PR03MB430.namprd03.prod.outlook.com (10.141.85.14) X-Microsoft-Exchange-Diagnostics-untrusted: 1;DM2PR03MB430;2:1ls3ho+nrRZCqd0HvLLIxiP/h2o+FekPK7UgaN+5r7wHKYHSCkoTz1XHEzNuPBNy;2:gAZgD1tNCS0Uucex8ispGAAk8Jed7ZynozAPCgHMwXCZET2cNkHirAD++OoIW2Yd10Rx0Jg1vKLusNTb7gADNoFYapzHnkJmc+l1Yq4G6qFncglFzGV00kyjw70a7whJLixUG5H3NXO+WyYkxLL5xA==;6:OYRqeU/sYirNAuobXKX2UMQ0lwJ1qL/+lAvcABzq9KdOqvPZVCLbOFGPBwfn1WV2NJPKTMGJyr9UD8zhN2OvG3wKw4pFNNMT7quudj6wkcNZNPS+60+CCozwrIJmotKMQq5imXi3mgDH5JM/8OznpQ==;3:zC4bPGu5kcXY4onHVVY3D5qcEFtXbUAFMtcUDZikKQPRR3/0ytOn1cmg0RbyVEx0EGlYmXO8qZTXvT6IQtGqcL0qYvd+m2xDXMsRoWeBNAb6psVC/+kHT1aHqOoDmTAs/e/o1s0gc/Jfyq/6qeJa0bYYnBX/d9gPzfvsr2C8gakljny8vjV5UU8OCwE+OuRfCD+zybrGSsTuVQKj47DMjDGoKQ9K65Yby/SJam5GQMkIpCzSQ8/D3q42bEv+TxeY2QnlhwnKhtwHjmUS2aBsIoGU93rOQ91C+Gyuo2RSEhQ= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB430;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB462;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1495; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DM2PR03MB430;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB430;BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN3PR03MB1495;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1495; X-Forefront-PRVS: 0577AD41D6 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(377454003)(24454002)(51704005)(479174004)(86362001)(42186005)(87976001)(50466002)(46102003)(4001350100001)(99136001)(33656002)(40100003)(5001960100002)(189998001)(19580405001)(80316001)(77096005)(43066003)(65956001)(66066001)(5001770100001)(47776003)(2950100001)(83506001)(122386002)(19580395003)(54356999)(87266999)(53806999)(23746002)(77156002)(62966003)(59896002)(65816999)(76176999)(50986999)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR03MB430;H:[137.57.160.203];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: =?Windows-1252?Q?1;DM2PR03MB430;9:fqCO03GwIbx6Ixi8+kYEd2KCw3NWl4IivrUT4sK?= =?Windows-1252?Q?/C13qlp+SiSy5MiLcrCKxD5ZpYIMUjZQHacjb65o8PxIGyu4wQBYVUrH?= =?Windows-1252?Q?qA0zPwUoBjvNgRQ7c37+MJ6e+wMHFH+81BmSCl1tM/28Iyda5qULqVSv?= =?Windows-1252?Q?Pwm+gjDHBSAlBQLUmIY/XZguvVbmWgBIFezCAs5JPA/6/Go0XjHvrLhc?= =?Windows-1252?Q?ywiekBTsia5z1ATnlgD/7iKCRDNJ14tMR3xxQezjZn0XMeu4MJQuS+uK?= =?Windows-1252?Q?9ZpUHVJpYvix79/h8YSWGjOnvFcwVb+sKdOu3WTPW76urKQ86lxzMQRI?= =?Windows-1252?Q?CvjAYlcGIf0e4M+8vbtWf4ZbLXEzN53Bj0H5iHBuIouhiaAtdEyw4Zr/?= =?Windows-1252?Q?qb8/l2ws7Trtsk/DpVFXP//Ey4cqxkU0pfO/6s78weuY5w41UBsdGXRr?= =?Windows-1252?Q?x2rhIXS7h927w7S/8IQ3EhaivFrunwQ9nBoMKb6qcBkmvS7v7OmP/izI?= =?Windows-1252?Q?xga4L/dLQW2wq3bAR6iEclvSnMgnRG0zTDcAX0RgGpzv/1IwHIuwIegt?= =?Windows-1252?Q?AD4w6Q6Qsc/EtjuIKSPVqRli8ZD2bpGt6tt+LUMzlnyEVjfbY8eaCblK?= =?Windows-1252?Q?lItFAMG8VL4ZpmAslHfjkQQx2FN97dE/xvHSriojT/kXtLF9ueB4mZww?= =?Windows-1252?Q?fB6j6CbYVqnsTgLHokQI563jMBSpF2romz6qle8ijXtJ5dEqcqOCDJK/?= =?Windows-1252?Q?i9WQugV+DVY0ZsZyr4d6akrTTE43ZqG27F9TE49kCBO33b3+lbxez6nR?= =?Windows-1252?Q?7vpJ/hwMXav1A+f5+cC47pONjd7hCRb1yme5c/2qIl/OZS6DYGp1HGP3?= =?Windows-1252?Q?l5BTSuqJsWoe1QEiMPLvf74LOxhAv2SyEBGLM8ldrBvYRsQf5MG2XchF?= =?Windows-1252?Q?5XjczrxN29+yYlg2i83BkQxla9SHSN6WivZOV6/9q0KMt9BEGfVikIlT?= =?Windows-1252?Q?30u2kw26Cu3OnpBkwcsbwWrznoZtzhk6KtWd/P113VhCBRInvZ1dRZqm?= =?Windows-1252?Q?kw4Y0cYKwnpg9id9z9w1jFXRsdyq5t9AAdOFwg2PFJCvwDX73wxgrkNE?= =?Windows-1252?Q?KHxzezxsqW8krJrQWRz8=3D?= X-Microsoft-Exchange-Diagnostics-untrusted: 1;DM2PR03MB430;3:Y5/3Bc8m+q/PRf2p5tdnliELDRfGnT+EpBbH6JcOq/rv90i2PD/nRkVN7ezZdRL37aARY0jD/1mskfgSHEjTEOfuDSJD+wGvR+iMUykNaZCDP3VuTPLqnhQmzh8kno+dZgNs9dui/MGtpZ2mSXTrbg==;10:5HNvKXq/O14MrLBIdRqMcoh8pleaSJZ5i3UpeTKwrm0dRjbB1hzeRKiuBAGO2rht8i+rfVXiNwGgbWEzjkxgZisPIGxT0EhpN++ihLqm71E=;6:VEDRzWEA6mbxqUNfqGGgjGRuYMzWoW/eaBJdUpUiDJnVk7Dt1uh5wwFktBPuY+ZqaeybdLO0QDece9w7XfFzIcpeEzDoGKsonGLERkMB5i9YZEYXsEMNRD36Op8SR5XZuAcDnJCiqMaRAEmdWT6Pmg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB430 X-Microsoft-Exchange-Diagnostics-untrusted: 1;DM2PR03MB462;2:u/hWbNm4QG78U9I+8BYXwuTSon5RO+WM4/t7eafkc4iBNk6KEF47vExo0qEOER1D;2:tBXTx1YKUSEsJb9OJmbtI55NmySfOHP4CyDTTty+uxfQx9NZRHhJOIl8QVHHXDx0AzrDIuqq6mv3pF+xkkeoI5A7iasflF1R3tq/5sp8DXISr+uu3LT+A1RSVNCAqJg3Pf5ZXWw1VTPPLI88utVWEQ==;9:ZIdxjQ1OQaHp1Zj67MI90y+yY3xLYeHzZki4Ik0ZNnPzJQLeMS6xn/jKygCodQMgDs4WDiS+eiYLZJDUt0ep4ZLkr9qU7qEzKpHKXV27dtbxSDGDnFG9Ap8dHC+UkneYDWj0KrO5PWsgSB+Z6xl1HQ== X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BY2FFO11FD053.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD053;1:5ANdMJG8A60dND6pelI1M6WWKqGYaWaR2l3LBgZqA53PMYhjTkJFXUvBQmXrlm3sOw+U10BJg+bY2ai8YnnELK7fsUnw8j4UwV4i1JWmmXdeJ/iNDv01VFOvxbKKpjBnqblMrGegAX303DxUl5ciCTUI9vEn0l1dahIz3bkzQ/IAy0cNBabdwQaLExoFhAQIBfiZM8+uSUuu5kznEbEhJOummRNsLO6dtapdhaE0VtAgCGW1y6XLexadH7S86XTU5N9uwGYJiOfGg7Wa4exkoqWgkTQKqXD41/en1n5VqEnitNhXY51XUHfR+06TiA5a X-Forefront-Antispam-Report: CIP:66.35.236.227;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(339900001)(189002)(377454003)(199003)(24454002)(51704005)(479174004)(86362001)(106466001)(6806004)(81156007)(50466002)(87936001)(46102003)(90366008)(4001350100001)(99136001)(33656002)(40100003)(5001960100002)(189998001)(19580405001)(80316001)(77096005)(43066003)(85426001)(65956001)(66066001)(65806001)(5001770100001)(47776003)(2950100001)(83506001)(122386002)(64126003)(19580395003)(54356999)(87266999)(53806999)(105606002)(23746002)(77156002)(62966003)(59896002)(65816999)(76176999)(50986999)(7099028)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1495;H:sj-itexedge03.altera.priv.altera.com;FPR:;SPF:Fail;MLV:ovrnspm;MX:1;A:0;PTR:InfoDomainNonexistent;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1495;2:l/kUwWS/mDcYBr0I2D6XcmsECpMR9vBtFDURElnlhRkxz147Ggw/K5hMO63amZmd;2:t7X3XB5Q7wZ35UAini9n1W/Z1wbHzQti8liEHQ4juuI0ThuV9OabkD6N9wI3IPoP/4rBuzVR9xnw2t/6otjsKTLEUYVRGcgVBkjfcQVtIu3kOEf9Ct0WxDZTsu/rfFV8pVZ9hi6aqjSSwzCNkxkI/+gF063ghZ2CWROPGNjR5xZxIVnaReGMSB8aSdI6hhohO+I7h8gAzeT2r5RWsGmVXRQ9wi4TnSLYp97ow6tJNAU=;6:dBUhWuVHDj/OvbVWV8HPpQLjrUJGdIdXqetsoiOVofD3TwVtAViceHu7WK5o7023ei7xmJG7+UFnpYe+TkZIyixhraXGp745YUDL2WK7Ey2zgAe995NbJVy4gPVlt8xKn4V5PSPPcPWwJnFbB1xh5Q==;3:Lj3XHdfjnatqSmyj0GtZVCxhneyehUWuZq6Eq7WRflxW7AW6qpoWd/IZhGXfXIqO+G1sF6cNOOHcE0/l0cpZIfcTc6JUTm1cYLE0C7jwT/lUzbIc/nlTRYm78on9br3MPDAUU4PumsSaXVHHhv/yYrt8aDfNuVSrFJ3RpjGi6s79A9LKF+cwTvlZJs7ivTkBpAoQHSDqyoGVS4eBBEB9Sn+AHM+TR2H+C6B5DezrUvmXRyRoX9RyadEOa+TJGqByQg2s3Ra1yAqSbe21H7mDey6yYhqPrufSXiwoy5kdDwo= X-Forefront-PRVS: 0577AD41D6 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BN3PR03MB1495;9:5HT+gm4JbqpnLjLuTMPX+g2Amviy9907MFHTjg?= =?Windows-1252?Q?24W6h0KSY+N91lHWRCZbTteRqUE4Ehngg6XcKCGC0NARYgZsNMPegQhJ?= =?Windows-1252?Q?WFjxHzRY2rKrQliG7Un2O4sLNSDrXKaBoGVzsFHFAFbpUK01FpznEzeo?= =?Windows-1252?Q?gWb31S+RI8RJtf6dVi0xUXQ3XjYbJYat0mUiMRwgIh3GCeX5lwrosXcq?= =?Windows-1252?Q?rOJJdkqQoMip+UHJp1KACc3QpQsGZJv/BHnmNA9PIeZm1vnmHy42w6ht?= =?Windows-1252?Q?lddxNuxJTOCYswN5UPxx6fXEYWVkY8HH+k6b9otWbLaocNrZyR4M4gfy?= =?Windows-1252?Q?mQooiZsL+uV18QJzjKzBZhTzpg6OIbGLMnV592tg35aRHie5J097T9zt?= =?Windows-1252?Q?CY9hDOUAkTeVtm1ImNph6udl3DiKOIf7Q4FgRiAQNldcr4VOOrXjdV8f?= =?Windows-1252?Q?gZtr70p9hlcRlcmyApF3VayeWOoaQW/AsSjWm66pYWJQv8pJM7U8efbp?= =?Windows-1252?Q?/5PALJxFqNXnYdRsfzWMhYixB090sXL1MjUwzYu0DV1cTwTL9cmS5EeA?= =?Windows-1252?Q?PDAw9dE85DfKUAOeyyw8tsO29SxP4UNgJZTHKYPURMTWSrbnRHz8jVz3?= =?Windows-1252?Q?NAoAkC5oqzyZumYrijRTSIWNquhwLzY596vzuZGeBVBoOEsN2jDHe3PU?= =?Windows-1252?Q?i55UQcPIItjhaNANLGQeugIeMd/Lv6Ai6aQj+F+bplsWAd6IF1vaBG1O?= =?Windows-1252?Q?7AR49uNAjjrznenAUlvQaax/xRiI8hay3MW7kP2M0Z/pqvZPeLu2V2xh?= =?Windows-1252?Q?d/7QpdKTj5VpCjA11UT112hYYxHU35Nvj/X8eBYBEJh6uCKAGm/O19zC?= =?Windows-1252?Q?PWTkhAkRxW75Ea4QJf4Pnt9GV9er4P70KFPI1MyunNdQ62KN4zn6aHvw?= =?Windows-1252?Q?D090l/ZuiqJHACkOVPrGHhYUneYIEcD8Qo3dBtwLja4R++1pmD4IZqg6?= =?Windows-1252?Q?I52+ctStYhoJUvffLCDB2PZKgBCd5W/OmLkxH3EKiFiPcTP8buFVdoA1?= =?Windows-1252?Q?YYvfpA+c5gJ7Ew9vnErRcu0WWuMBK62//xV68h9kRMLVKnF5WkX3S3t4?= =?Windows-1252?Q?kRe0z3B+PoiLa9l8dSYO+ppg2oaD2FQzx2pYARhpwAp3cW4Q9dMokoR2?= =?Windows-1252?Q?uZfuhJf6Kkf3brbSHHuSZrg2TYgt9NZR1zpVag8sxPmegMMkmlElqnN/?= =?Windows-1252?Q?l26JL0fm8EaChBuvG80C5oal47nl5fqKsCbvc8+VziKzU4kk/Layx/Xy?= =?Windows-1252?Q?Yyee57zGSIYfsUV8LqKEGtvr5oFoqLkTL43vXa3RWlyZau527fKCK6kx?= =?Windows-1252?Q?EDQBjMaAN0?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR03MB1495;3:v3MJZE8Xha8bG3m3gI+6wevchbcB1QmWHcRZPLNtwVFuZosHUIfudu3DIURJ40pgS1mOiY5XjxyJbAiTTpkZglPO4nQZfbddi47yAMtYPbWK507P4JIoI00HmMoUWih3VX+QDOMMN+I04b6gYN7hGA==;10:4n3fq1HTrfbFRxupAuCQWCamftYZ/fj0rZZfpLavjpc1DGz8M7mm/oREd9nz/zwdTrzftIeTJXx0ghNx4fu1fNLuv7A2q7lBpxQsP+FN7HA=;6:mcVWOsLlya5/lkrotf+V1fS7vRxqb3WYOkKRZevS5bF3YpjXyP4/hv/u373BKOr9ViSZa5OAo1emE9WmFCjVXD2duethtaLRIiZyNynya36I1XuBR2mcQvmlTiH3m4jTSqLhKtHf1RTTiDvdFWKkDg== X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 May 2015 21:00:11.3060 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.227];Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1495 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 05/15/2015 05:55 AM, Arnd Bergmann wrote: > On Wednesday 13 May 2015 16:49:47 tthayer@opensource.altera.com wrote: >> + sdr: sdr@ffc25000 { >> + compatible = "syscon"; >> + reg = <0xffcfb100 0x80>; >> + }; >> + >> > > A syscon node with just 128 bytes seems very odd. Can you check the > hardware manual to see if this is part of some bigger unit? > > Arnd > This is an unfortunate legacy of our previous SDRAM controller (in the CycloneV) which had ECC registers interspersed with registers other drivers needed - thus the use of syscon. In the Arria10 chip, the ECC registers are in their own partitioned group but I kept the syscon to remain consistent with the Device Tree bindings from the CycloneV family. I've implemented your other suggestions. Thank you for reviewing! Thor