From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D977C433EF for ; Fri, 8 Apr 2022 16:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237960AbiDHQQm convert rfc822-to-8bit (ORCPT ); Fri, 8 Apr 2022 12:16:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237821AbiDHQQC (ORCPT ); Fri, 8 Apr 2022 12:16:02 -0400 Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5528BE09E for ; Fri, 8 Apr 2022 09:13:52 -0700 (PDT) Received: from ip5b412258.dynamic.kabel-deutschland.de ([91.65.34.88] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncrEz-0004it-3M; Fri, 08 Apr 2022 18:13:41 +0200 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: Christoph Hellwig Cc: palmer@dabbelt.com, paul.walmsley@sifive.com, aou@eecs.berkeley.edu, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, wefu@redhat.com, liush@allwinnertech.com, guoren@kernel.org, atishp@atishpatra.org, anup@brainfault.org, drew@beagleboard.org, hch@lst.de, arnd@arndb.de, wens@csie.org, maxime@cerno.tech, gfavor@ventanamicro.com, andrea.mondelli@huawei.com, behrensj@mit.edu, xinhaoqu@huawei.com, mick@ics.forth.gr, allen.baum@esperantotech.com, jscheid@ventanamicro.com, rtrauben@gmail.com, samuel@sholland.org, cmuellner@linux.com, philipp.tomsich@vrull.eu Subject: Re: [PATCH v8 10/14] riscv: add cpufeature handling via alternatives Date: Fri, 08 Apr 2022 18:13:39 +0200 Message-ID: <5557228.DvuYhMxLoT@diego> In-Reply-To: <20220331100139.GG23422@lst.de> References: <20220324000710.575331-1-heiko@sntech.de> <20220324000710.575331-11-heiko@sntech.de> <20220331100139.GG23422@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="iso-8859-1" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Christoph, Am Donnerstag, 31. März 2022, 12:01:39 CEST schrieb Christoph Hellwig: > Can you please fold the somewhat confusingly named vendor patching > into this instead of keeping that magic standalone function pointer > mess? I'm not sure it's what you meant, but I did merge patches 10+11 (cpufeatures + svpbmt), as having them separate created build warnings / errors, when a bisected build happens (aka up to patch10 but without patch11) The vendor-patch-func got an overhaul in patch13 "riscv: don't use global static vars to store alternative data" > > +static const struct cpufeature_info __initdata_or_module cpufeature_list[CPUFEATURE_NUMBER] = { > > +}; > > Overly lone line. ok, I'll wrap that line Heiko