From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753343AbbERJsw (ORCPT ); Mon, 18 May 2015 05:48:52 -0400 Received: from mga14.intel.com ([192.55.52.115]:28653 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753255AbbERJsm (ORCPT ); Mon, 18 May 2015 05:48:42 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,452,1427785200"; d="scan'208";a="572995957" Message-ID: <5559B574.7070402@linux.intel.com> Date: Mon, 18 May 2015 17:48:36 +0800 From: Jiang Liu Organization: Intel User-Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Thomas Gleixner CC: linux-kernel@vger.kernel.org Subject: Are we still willing to pay the cost of moving include/linux/irqdesc.h into kernel/irq/? Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Thomas, When refining irq related data structures, I found once we had a plan to move include/linux/irqdesc.h into kernel/irq/, and I have basic ideas about how to achieve the goal as: 1) de-inline accessor functions in irqdesc.h and move the declaration into linux/irq.h. 2) remove reference to irq_desc->xxxx from drivers one by one (this step is simple) 3) remove reference to irq_desc->xxxx from arch (this step is hard) 4) move irqdesc.h into kernel/irq/ But are we still willing to pay the cost of converting inline access helpers into normal functions? One possible tradeoff is to remove reference of irq_desc->xxxx from drivers/, which is straight forward and shouldn't cause serious performance regressions:) Thanks! Gerry