From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753033AbbERRCB (ORCPT ); Mon, 18 May 2015 13:02:01 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:34100 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbbERRCA (ORCPT ); Mon, 18 May 2015 13:02:00 -0400 Message-ID: <555A1B04.4080104@plumgrid.com> Date: Mon, 18 May 2015 10:01:56 -0700 From: Alexei Starovoitov User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Wang Nan , paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, acme@kernel.org, namhyung@kernel.org, jolsa@kernel.org, dsahern@gmail.com, daniel@iogearbox.net, brendan.d.gregg@gmail.com, masami.hiramatsu.pt@hitachi.com CC: lizefan@huawei.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [RFC PATCH v3 02/37] perf tools: Set vmlinux_path__nr_entries to 0 in vmlinux_path__exit References: <1431860222-61636-1-git-send-email-wangnan0@huawei.com> <1431860222-61636-3-git-send-email-wangnan0@huawei.com> In-Reply-To: <1431860222-61636-3-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/17/15 3:56 AM, Wang Nan wrote: > Original vmlinux_path__exit() doesn't revert vmlinux_path__nr_entries > to its original state. After the while loop vmlinux_path__nr_entries > becomes -1 instead of 0. This makes a problem that, if runs twice, > during the second run vmlinux_path__init() will set vmlinux_path[-1] > to strdup("vmlinux"), corrupts random memory. > > This patch reset vmlinux_path__nr_entries to 0 after the while loop. > > Signed-off-by: Wang Nan > Acked-by: Namhyung Kim no need to repost. Arnaldo picked it up already. When you repost it many times, it gets very confusing. If patch is not moving, rather ping it in original thread. Same with patches 3,4,5.