From: "Christian König" <christian.koenig@amd.com>
To: Denys Vlasenko <dvlasenk@redhat.com>
Cc: Alex Deucher <alexander.deucher@amd.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] radeon: Deinline indirect register accessor functions
Date: Mon, 18 May 2015 21:04:44 +0200 [thread overview]
Message-ID: <555A37CC.2020809@amd.com> (raw)
In-Reply-To: <555A3461.90000@redhat.com>
On 18.05.2015 20:50, Denys Vlasenko wrote:
> On 05/18/2015 08:06 PM, Christian König wrote:
>> I'm actually surprised how often people come along with that. The last time we tried this it caused a noticeable performance drop.
>>
>> Basic problem is that this line:
>>> + if ((reg < rdev->rmmio_size || reg < RADEON_MIN_MMIO_SIZE) && !always_indirect)
>> optimizes away in most of the cases which reduces the call to a readl which is way faster than the spinlock path.
>>
>> So this is a NAK,
>
> Fair enough.
>
> I'm preparing a v2 where the fast branch of r100_mm_{r,w}reg() will stay inlined.
>
Sounds good to be, but IIRC that was suggested the last time this came
up as well. You might just want to google a bit why it wasn't done like
this before submitting the patch for review.
BTW: Please CC the dri-devel list as well, cause not everybody is
reading on linux-kernel.
Regards,
Christian.
next prev parent reply other threads:[~2015-05-18 19:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 17:59 [PATCH] radeon: Deinline indirect register accessor functions Denys Vlasenko
2015-05-18 17:59 ` [PATCH] radeon: Shrink radeon_ring_write() Denys Vlasenko
2015-05-18 18:11 ` Christian König
2015-05-18 18:25 ` Denys Vlasenko
2015-05-18 19:01 ` Christian König
2015-05-18 18:06 ` [PATCH] radeon: Deinline indirect register accessor functions Christian König
2015-05-18 18:50 ` Denys Vlasenko
2015-05-18 19:04 ` Christian König [this message]
2015-05-18 19:22 ` Ilia Mirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555A37CC.2020809@amd.com \
--to=christian.koenig@amd.com \
--cc=alexander.deucher@amd.com \
--cc=dvlasenk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox