From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754618AbbERTE4 (ORCPT ); Mon, 18 May 2015 15:04:56 -0400 Received: from mail-by2on0106.outbound.protection.outlook.com ([207.46.100.106]:2212 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753970AbbERTEz convert rfc822-to-8bit (ORCPT ); Mon, 18 May 2015 15:04:55 -0400 Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=amd.com; redhat.com; dkim=none (message not signed) header.d=none; X-WSS-ID: 0NOK7NZ-07-933-02 X-M-MSG: Message-ID: <555A37CC.2020809@amd.com> Date: Mon, 18 May 2015 21:04:44 +0200 From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Denys Vlasenko CC: Alex Deucher , Subject: Re: [PATCH] radeon: Deinline indirect register accessor functions References: <1431971955-31231-1-git-send-email-dvlasenk@redhat.com> <555A2A1E.9000706@amd.com> <555A3461.90000@redhat.com> In-Reply-To: <555A3461.90000@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [10.224.50.12] Content-Transfer-Encoding: 8BIT X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11FD056;1:ouv9V55pJM4zSGXZABDxdDACjGgzy7s4WpPien7BOQjBwSIQKUaEyT82IQxAgGHizW3nA3tHtAWJKWoHV9KxoJgoGfy3+htz+wpVvlVULiODWYzhzqNnpot61n3yOFhZkEjRb9iUXjTdKKVUeHtYXka1kuS2DFiye4QzO2gdEeMhB83Z3H/sEvPdYqGMdql3ULV8EPeMN7vr9+GtE0/Irgc5NE66vlTvEHhrLMSZ/VfP1Pk1VJKj8T8G7tXGYdJzSo0w6GrGT53MUAeWoM1mnQ== X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(51704005)(199003)(189002)(24454002)(479174004)(377454003)(65806001)(87936001)(77156002)(4001350100001)(62966003)(65956001)(85182001)(47776003)(50466002)(76176999)(65816999)(101416001)(86362001)(87266999)(64706001)(54356999)(50986999)(105586002)(4001540100001)(68736005)(97736004)(46102003)(92566002)(77096005)(2950100001)(64126003)(106466001)(85202003)(33656002)(23676002)(110136002)(189998001)(5001830100001)(5001860100001)(5001920100001)(59896002)(36756003)(80316001)(83506001)(3940600001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB072;H:atltwp01.amd.com;FPR:;SPF:None;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB072; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN1PR02MB072;BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB072; X-Forefront-PRVS: 058043A388 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2015 19:04:49.5743 (UTC) X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.221];Helo=[atltwp01.amd.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR02MB072 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18.05.2015 20:50, Denys Vlasenko wrote: > On 05/18/2015 08:06 PM, Christian König wrote: >> I'm actually surprised how often people come along with that. The last time we tried this it caused a noticeable performance drop. >> >> Basic problem is that this line: >>> + if ((reg < rdev->rmmio_size || reg < RADEON_MIN_MMIO_SIZE) && !always_indirect) >> optimizes away in most of the cases which reduces the call to a readl which is way faster than the spinlock path. >> >> So this is a NAK, > > Fair enough. > > I'm preparing a v2 where the fast branch of r100_mm_{r,w}reg() will stay inlined. > Sounds good to be, but IIRC that was suggested the last time this came up as well. You might just want to google a bit why it wasn't done like this before submitting the patch for review. BTW: Please CC the dri-devel list as well, cause not everybody is reading on linux-kernel. Regards, Christian.