From: "H. Peter Anvin" <hpa@zytor.com>
To: Borislav Petkov <bp@alien8.de>, Brian Gerst <brgerst@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
the arch/x86 maintainers <x86@kernel.org>,
Andy Lutomirski <luto@amacapital.net>,
Denys Vlasenko <dvlasenk@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>,
Igor Mammedov <imammedo@redhat.com>,
Fenghua Yu <fenghua.yu@intel.com>
Subject: Re: [PATCH] x86, cpuinfo fix cpu_data(0) x86_model_id field truncation
Date: Mon, 18 May 2015 13:53:57 -0700 [thread overview]
Message-ID: <555A5165.8020500@zytor.com> (raw)
In-Reply-To: <20150518203600.GH23618@pd.tnic>
On 05/18/2015 01:36 PM, Borislav Petkov wrote:
> On Mon, May 18, 2015 at 04:27:02PM -0400, Brian Gerst wrote:
>> The problem here is that strim() modifies the string in place,
>> replacing the first trailing space with a null. I think the best
>> solution is to do the trimming in get_model_name(). It already trims
>> leading spaces for Intel.
>
> Sounds good - start from the 48th position forward to the first non \s
> char. Yeah.
>
Yes, we should trim both leading and trailing spaces.
-hpa
next prev parent reply other threads:[~2015-05-18 20:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 18:21 [PATCH] x86, cpuinfo fix cpu_data(0) x86_model_id field truncation Prarit Bhargava
2015-05-18 19:45 ` Borislav Petkov
2015-05-18 20:27 ` Brian Gerst
2015-05-18 20:36 ` Borislav Petkov
2015-05-18 20:53 ` H. Peter Anvin [this message]
2015-05-18 22:04 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555A5165.8020500@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=brgerst@gmail.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvlasenk@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=imammedo@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@redhat.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=prarit@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox