Re: [PATCH 14/19] x86, mpx: new directory entry to addr helper

Thomas Gleixner
2015-05-18T21:10:42Z

On Fri, 8 May 2015, Dave Hansen wrote:
> Currently, to get from a bounds directory entry to the virtual
> address of a bounds table, we simply mask off a few low bits.
> However, the set of bits we mask off is different for 32 and
> 64-bit binaries.
>
> This breaks the operation out in to a helper function and also
> adds a temporary variable to store the result until we are
> sure we are returning one.
>
> Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>

> +static unsigned long mpx_bd_entry_to_bt_addr(struct mm_struct *mm,
> + unsigned long bd_entry)

Nit: Please adjust the second line so the arguments are horizontally
aligned.

static unsigned long mpx_bd_entry_to_bt_addr(struct mm_struct *mm,
unsigned long bd_entry)

Aside of that: Reviewed-by: Thomas Gleixner <tglx@linutronix.de>