public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Wim de With <nauxuron@wimdewith.com>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: benjamin.romer@unisys.com, david.kershner@unisys.com,
	gregkh@linuxfoundation.org, sparmaintainer@unisys.com,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c
Date: Tue, 19 May 2015 01:22:24 +0200	[thread overview]
Message-ID: <555A7430.9030105@wimdewith.com> (raw)
In-Reply-To: <wrfjk2w6kvv0.fsf@redhat.com>

On 18-5-2015 12:45, Jes Sorensen wrote:
> Wim de With <nauxuron@wimdewith.com> writes:
>> This is a patch that fixes the function declarations in
>> visorbus/visorchipset.c by removing newlines after the function return
>> type
> 
> This patch doesn't fix things, it makes things worse!
> 
> If you want to post patches to this, do it properly and check the output
> first.
> 
> NACK
> 
> Jes

But how is line breaking in function headers supposed to be done? The
coding style documentation specifically state the following:
"Descendants are always substantially shorter than the parent and are
placed substantially to the right. The same applies to function headers
with a long argument list."

I really don't want to bother you with trivial patches, especially when
they are incorrect, but I am trying to learn something, so I hope you
will help me out.

Wim










      reply	other threads:[~2015-05-18 23:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18  9:45 [PATCH] Staging: unisys: fix function declaration format in visorchipset.c Wim de With
2015-05-18 10:24 ` Sudip Mukherjee
2015-05-18 10:45 ` Jes Sorensen
2015-05-18 23:22   ` Wim de With [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555A7430.9030105@wimdewith.com \
    --to=nauxuron@wimdewith.com \
    --cc=Jes.Sorensen@redhat.com \
    --cc=benjamin.romer@unisys.com \
    --cc=david.kershner@unisys.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sparmaintainer@unisys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox