From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755215AbbERXWc (ORCPT ); Mon, 18 May 2015 19:22:32 -0400 Received: from wimdewith.com ([188.226.197.86]:42550 "EHLO wimdewith.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754994AbbERXWb (ORCPT ); Mon, 18 May 2015 19:22:31 -0400 Message-ID: <555A7430.9030105@wimdewith.com> Date: Tue, 19 May 2015 01:22:24 +0200 From: Wim de With User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Jes Sorensen CC: benjamin.romer@unisys.com, david.kershner@unisys.com, gregkh@linuxfoundation.org, sparmaintainer@unisys.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c References: <1431942349-29351-1-git-send-email-nauxuron@wimdewith.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18-5-2015 12:45, Jes Sorensen wrote: > Wim de With writes: >> This is a patch that fixes the function declarations in >> visorbus/visorchipset.c by removing newlines after the function return >> type > > This patch doesn't fix things, it makes things worse! > > If you want to post patches to this, do it properly and check the output > first. > > NACK > > Jes But how is line breaking in function headers supposed to be done? The coding style documentation specifically state the following: "Descendants are always substantially shorter than the parent and are placed substantially to the right. The same applies to function headers with a long argument list." I really don't want to bother you with trivial patches, especially when they are incorrect, but I am trying to learn something, so I hope you will help me out. Wim