From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755321AbbESABY (ORCPT ); Mon, 18 May 2015 20:01:24 -0400 Received: from www.sr71.net ([198.145.64.142]:46268 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755270AbbESABV (ORCPT ); Mon, 18 May 2015 20:01:21 -0400 Message-ID: <555A7D4D.5090403@sr71.net> Date: Mon, 18 May 2015 17:01:17 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Gleixner CC: linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com, oleg@redhat.com, bp@alien8.de, riel@redhat.com, sbsiddha@gmail.com, luto@amacapital.net, mingo@redhat.com, hpa@zytor.com, fenghua.yu@intel.com Subject: Re: [PATCH 03/19] x86, mpx: use new tsk_get_xsave_addr() References: <20150508185948.4C19F4B0@viggo.jf.intel.com> <20150508185949.3250100D@viggo.jf.intel.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/18/2015 01:36 PM, Thomas Gleixner wrote: >> > #ifdef CONFIG_X86_INTEL_MPX >> > siginfo_t *mpx_generate_siginfo(struct pt_regs *regs, >> > - struct xsave_struct *xsave_buf); >> > -int mpx_handle_bd_fault(struct xsave_struct *xsave_buf); >> > + struct task_struct *tsk); >> > +int mpx_handle_bd_fault(struct task_struct *tsk); > So you still keep *tsk and remove it in the next patch. I guess either > ordering has its value, so no problem to do it this way. I agree that this looks a bit goofy. Originally, this patch just passed around 'tsk' instead of 'xsave_buf'. But I realized we could go a step further. The way it stands, it is bisectable and been built in this configuration for a month or two. I'd really like to keep it this way if possible, even though it looks a bit goofy.