From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752369AbbESAQd (ORCPT <rfc822;w@1wt.eu>);
	Mon, 18 May 2015 20:16:33 -0400
Received: from mailout3.w1.samsung.com ([210.118.77.13]:62288 "EHLO
	mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750861AbbESAQa (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 18 May 2015 20:16:30 -0400
X-AuditID: cbfec7f5-f794b6d000001495-d1-555a80db25ec
Message-id: <555A80DA.5030700@samsung.com>
Date: Tue, 19 May 2015 09:16:26 +0900
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101
 Thunderbird/31.7.0
MIME-version: 1.0
To: Joe Perches <joe@perches.com>, Chanwoo Choi <cw00.choi@samsung.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
        Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] regulator: max77686: fix gpio_enabled shift wrapping bug
References: <20150515092501.GB21508@mwanda> <5555C814.7030405@samsung.com>
 <1431968463.2870.34.camel@perches.com>
In-reply-to: <1431968463.2870.34.camel@perches.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrELMWRmVeSWpSXmKPExsVy+t/xq7q3G6JCDXZO0bKY+vAJm8X1L89Z
	LV7/m85iMfv+YxaL1y8MLbbekrb4dqWDyeLyrjlsDhweO2fdZffYtKqTzePj01ssHl9WXWP2
	6NuyitHj8ya5ALYoLpuU1JzMstQifbsErozf98+zFizgqNizfAVrA+NLti5GTg4JAROJz6tu
	QdliEhfurQeyuTiEBJYySuxrucsM4TxllHi6+xILSBWvgJZEW8stdhCbRUBV4v7d12A2m4Cx
	xOblS8AmiQpESLy9fJIJol5Q4sfke2C9IgLuEl+v7WcHGcossJVR4s2X80BFHBzCAr4S93dX
	gNQICRRLrN7ymRHE5gSa+WDSC1aQEmYBPYn7F7VAwswC8hKb17xlnsAoMAvJhlkIVbOQVC1g
	ZF7FKJpamlxQnJSea6RXnJhbXJqXrpecn7uJERLyX3cwLj1mdYhRgINRiYd3hV9kqBBrYllx
	Ze4hRgkOZiUR3g0VUaFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeWfueh8iJJCeWJKanZpakFoE
	k2Xi4JRqYJQ0l8h+weWyWvXrykX3fxvVbnpRpSgSkec1Izh1LdO1g1aKZf13s5xW5F3w7Pz3
	xzbfbH3YJC5/eZNMrTeJL/Q4i4X5zI9JtX425Yhen39q+rdnqnrnvgZ72zidSPk8/aVgWdz7
	zSerns6eM09o5TSFlVEtWzVUJv7lLHE+cmlfqv/3ey4BX5RYijMSDbWYi4oTAezWFaB1AgAA
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19.05.2015 02:01, Joe Perches wrote:
> The code should handle more than 32 bits here because "id"
> can be a value up to MAX77686_REGULATORS (currently 34).
> 
> Convert the gpio_enabled type to DECLARE_BITMAP and use
> test_bit/set_bit.
> 
> Fixes: 3307e9025d29 ("regulator: max77686: Add GPIO control")
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Joe Perches <joe@perches.com>

Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Again - why you do not add CC-stable? If you need observational bug
effect to the commit message you can add:

<<When max77686 regulator was configured to GPIO controlled mode, the
overflow of 32 bit regulator ID could switch off completely different
regulators. This could happen because for other regulators the value of
"GPIO controlled mode" means "disabled".>>

Although I did not saw such effect of overflow in testing, it actually
should happen looking at the code.

Best regards,
Krzysztof