From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932422AbbESNaD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 19 May 2015 09:30:03 -0400
Received: from bear.ext.ti.com ([192.94.94.41]:37959 "EHLO bear.ext.ti.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932241AbbESN34 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 19 May 2015 09:29:56 -0400
Message-ID: <555B3AB2.6000100@ti.com>
Date: Tue, 19 May 2015 18:59:22 +0530
From: Kishon Vijay Abraham I <kishon@ti.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0
MIME-Version: 1.0
To: Arnd Bergmann <arnd@arndb.de>
CC: <linux-kernel@vger.kernel.org>, Tony Lindgren <tony@atomide.com>,
        Bin Liu <binmlist@gmail.com>, Brian Hutchinson <b.hutchman@gmail.com>,
        Felipe Balbi <balbi@ti.com>,
        Matthijs van Duin <matthijsvanduin@gmail.com>,
        <linux-omap@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] phy: add dm816x dependency on USB_PHY
References: <3934365.TiRUES6WLp@wuerfel>
In-Reply-To: <3934365.TiRUES6WLp@wuerfel>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Arnd,

On Tuesday 19 May 2015 06:32 PM, Arnd Bergmann wrote:
> The newly added phy-dm816x-usb driver depends on the
> usb phy API and fails to link if that is disabled:
>
> drivers/built-in.o: In function `dm816x_usb_phy_remove':
> :(.text+0x3a28): undefined reference to `usb_remove_phy'
> drivers/built-in.o: In function `dm816x_usb_phy_probe':
> :(.text+0x3c18): undefined reference to `usb_add_phy_dev'

A patch to fix this has already been queued in the fixes branch
https://git.kernel.org/cgit/linux/kernel/git/kishon/linux-phy.git/commit/?h=fixes&id=7f7a4d306ff87502dc26860f54e798693cf9b1e1

Thanks
Kishon
>
> This adds an explicit dependency in Kconfig to avoid the
> build error in randconfig tests.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 609adde838f4 ("phy: Add a driver for dm816x USB PHY")
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index fceac96c2a31..1b5c235562c9 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -37,7 +37,7 @@ config ARMADA375_USBCLUSTER_PHY
>
>   config PHY_DM816X_USB
>   	tristate "TI dm816x USB PHY driver"
> -	depends on ARCH_OMAP2PLUS
> +	depends on ARCH_OMAP2PLUS && USB_PHY
>   	select GENERIC_PHY
>   	help
>   	  Enable this for dm816x USB to work.
>