From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Arnd Bergmann <arnd@arndb.de>
Cc: Olof Johansson <olof@lixom.net>,
Boris BREZILLON <boris.brezillon@free-electrons.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Kevin Hilman <khilman@kernel.org>
Subject: Re: [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family
Date: Tue, 19 May 2015 15:53:04 +0200 [thread overview]
Message-ID: <555B4040.2090302@atmel.com> (raw)
In-Reply-To: <555B3A92.7010409@atmel.com>
Le 19/05/2015 15:28, Nicolas Ferre a écrit :
> Le 19/05/2015 15:02, Nicolas Ferre a écrit :
>> Le 19/05/2015 14:33, Alexandre Belloni a écrit :
>>> On 19/05/2015 at 13:04:22 +0200, Arnd Bergmann wrote :
>>>>>> @@ -250,15 +261,18 @@ CONFIG_SERIAL_FSL_LPUART=y
>>>>>> CONFIG_SERIAL_FSL_LPUART_CONSOLE=y
>>>>>> CONFIG_SERIAL_ST_ASC=y
>>>>>> CONFIG_SERIAL_ST_ASC_CONSOLE=y
>>>>>> +CONFIG_HW_RANDOM=y
>>>>>> CONFIG_I2C_CHARDEV=y
>>>>>> CONFIG_I2C_DAVINCI=y
>>>>>> CONFIG_I2C_MUX=y
>>>>
>>>> seems non-essential.
>>>>
>>>
>>> That is an oversight, it should be compiled as a module.
>>
>> Ok, I modify it: no need to bother sending a new revision.
>>
>>>>>> @@ -502,6 +522,8 @@ CONFIG_RTC_DRV_MV=y
>>>>>> CONFIG_RTC_DRV_TEGRA=y
>>>>>> CONFIG_DMADEVICES=y
>>>>>> CONFIG_DW_DMAC=y
>>>>>> +CONFIG_AT_HDMAC=y
>>>>>> +CONFIG_AT_XDMAC=y
>>>>>> CONFIG_MV_XOR=y
>>>>>> CONFIG_TEGRA20_APB_DMA=y
>>>>>> CONFIG_SH_DMAE=y
>>>>
>>>> What are these required for? I assume you need them for MMC? If so, that's
>>>> fine.
>>>>
>>>
>>> That is indeed the reason.
>>
>> Yep.
>>
>> So I simply do a s/y/m/ on the CONFIG_HW_RANDOM then included it in our
>> at91-4.2-defconfig branch.
>
> In fact it's a boolean. So removing it does the trick.
Wrong: it's a tristate: sorry for the noise. But removing is the way to
go anyway...
Bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2015-05-19 13:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 9:01 [PATCH] ARM: multi_v7_defconfig: Add Atmel SAMA5 family Alexandre Belloni
2015-05-19 9:15 ` Nicolas Ferre
2015-05-19 11:04 ` Arnd Bergmann
2015-05-19 12:33 ` Alexandre Belloni
2015-05-19 13:02 ` Nicolas Ferre
2015-05-19 13:28 ` Nicolas Ferre
2015-05-19 13:53 ` Nicolas Ferre [this message]
2015-05-20 13:53 ` Kevin Hilman
2015-05-20 14:08 ` Alexandre Belloni
2015-05-20 14:59 ` Kevin Hilman
2015-05-20 21:29 ` Alexandre Belloni
2015-05-20 15:18 ` Robert Nelson
2015-05-20 21:22 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555B4040.2090302@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox