From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755980AbbESN7v (ORCPT ); Tue, 19 May 2015 09:59:51 -0400 Received: from smtp.citrix.com ([66.165.176.89]:47410 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755332AbbESN7t (ORCPT ); Tue, 19 May 2015 09:59:49 -0400 X-IronPort-AV: E=Sophos;i="5.13,458,1427760000"; d="scan'208";a="264019525" Message-ID: <555B41D1.7010400@citrix.com> Date: Tue, 19 May 2015 14:59:45 +0100 From: David Vrabel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Julien Grall , CC: , , , , David Vrabel , Boris Ostrovsky , Subject: Re: [Xen-devel] [RFC 13/23] xen/xenbus: Use Xen page definition References: <1431622863-28575-1-git-send-email-julien.grall@citrix.com> <1431622863-28575-14-git-send-email-julien.grall@citrix.com> In-Reply-To: <1431622863-28575-14-git-send-email-julien.grall@citrix.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/05/15 18:00, Julien Grall wrote: > The xenstore ring is always based on the page granularity of Xen. [...] > --- a/drivers/xen/xenbus/xenbus_probe.c > +++ b/drivers/xen/xenbus/xenbus_probe.c > @@ -713,7 +713,7 @@ static int __init xenstored_local_init(void) > > xen_store_mfn = xen_start_info->store_mfn = > pfn_to_mfn(virt_to_phys((void *)page) >> > - PAGE_SHIFT); > + XEN_PAGE_SHIFT); This is page_to_mfn() that you adjusted in the previous patch. David