From: Richard Weinberger <richard@nod.at>
To: Fabian Frederick <fabf@skynet.be>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>
Subject: Re: [PATCH 6/6 linux-next] ubifs: remove else after return
Date: Tue, 19 May 2015 19:57:15 +0200 [thread overview]
Message-ID: <555B797B.90309@nod.at> (raw)
In-Reply-To: <1796356142.534811.1432057342188.open-xchange@webmail.nmp.proximus.be>
Am 19.05.2015 um 19:42 schrieb Fabian Frederick:
> All was compiled but untested.
Can you please test your changes too?
Trivial looking changes introduce sometimes issues and having them
tested would be wonderful.
You can test UBIFS using nandsim or mtdram on any Linux
system.
See: http://www.linux-mtd.infradead.org/faq/nand.html#L_nand_nandsim
Thanks,
//richard
next prev parent reply other threads:[~2015-05-19 17:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 21:43 [PATCH 1/6 linux-next] ubifs: remove unnecessary semi-colon Fabian Frederick
2015-05-15 21:43 ` [PATCH 2/6 linux-next] ubifs: simplify return in shrink_liability() Fabian Frederick
2015-05-15 21:43 ` [PATCH 3/6 linux-next] ubifs: simplify return in layout_cnodes() Fabian Frederick
2015-05-15 21:43 ` [PATCH 4/6 linux-next] ubifs: simplify return in sort_nodes() Fabian Frederick
2015-05-15 21:43 ` [PATCH 5/6 linux-next] ubifs: remove unnecessary else after break Fabian Frederick
2015-05-19 21:45 ` Brian Norris
2015-05-15 21:44 ` [PATCH 6/6 linux-next] ubifs: remove else after return Fabian Frederick
2015-05-18 22:17 ` Richard Weinberger
2015-05-19 17:42 ` Fabian Frederick
2015-05-19 17:57 ` Richard Weinberger [this message]
2015-05-22 21:37 ` Fabian Frederick
2015-05-22 21:46 ` Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555B797B.90309@nod.at \
--to=richard@nod.at \
--cc=adrian.hunter@intel.com \
--cc=dedekind1@gmail.com \
--cc=fabf@skynet.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox