Re: [RFC PATCH v3 30/37] perf bpf: Add bpf-loader and open ELF object files

Jiri Olsa
2015-05-22T17:24:47Z

On Sun, May 17, 2015 at 10:56:55AM +0000, Wang Nan wrote:

SNIP

> +#define DEFINE_PRINT_FN(name, level) \
> +static int libbpf_##name(const char *fmt, ...) \
> +{ \
> + va_list args; \
> + int ret; \
> + \
> + va_start(args, fmt); \
> + ret = veprintf(level, verbose, pr_fmt(fmt), args);\
> + va_end(args); \
> + return ret; \
> +}
> +
> +DEFINE_PRINT_FN(warning, 0)
> +DEFINE_PRINT_FN(info, 0)
> +DEFINE_PRINT_FN(debug, 1)
> +
> +static bool libbpf_inited = false;
> +
> +#define MAX_OBJECTS 128
> +
> +struct {
> + struct bpf_object *objects[MAX_OBJECTS];
> + size_t nr_objects;
> +} params;

apart from that we dont like this kind of static stuff, this seems like
nice case for having simple handler like 'struct bpf_objects' carrying
the above data.. what do I miss?

also params should actually be static right?

jirka