Re: [RFC PATCH v3 32/37] perf bpf: Parse probe points of eBPF programs during preparation

Jiri Olsa
2015-05-22T17:25:03Z

On Sun, May 17, 2015 at 10:56:57AM +0000, Wang Nan wrote:

SNIP

> + if (pev)
> + clear_perf_probe_event(pev);
> + return err;
> +}
> +
> int bpf_prepare_load(const char *filename)
> {
> struct bpf_object *obj;
> @@ -81,6 +150,8 @@ int bpf_prepare_load(const char *filename)
> return -EINVAL;
> }
> pr_debug("bpf: add program '%s'\n", title);
> +
> + bpf_do_config(params.nr_progs - 1, title);

shouldn't you check&pass return value of bpf_do_config ?

jirka