Re: [RFC PATCH v3 20/37] bpf tools: Add bpf.c/h for common bpf operations

Jiri Olsa
2015-05-22T17:24:14Z

On Sun, May 17, 2015 at 10:56:45AM +0000, Wang Nan wrote:

SNIP

> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> new file mode 100644
> index 0000000..1e9a53b
> --- /dev/null
> +++ b/tools/lib/bpf/bpf.h
> @@ -0,0 +1,17 @@
> +/*
> + * common eBPF ELF operations.
> + *
> + * Copyright (C) 2015, Wang Nan <wangnan0@huawei.com>
> + * Copyright (C) 2015, Huawei Inc.
> + *
> + * Released under the GPL v2. (and only v2, not any later version)
> + */
> +#ifndef __LIBBPF_BPF_H
> +#define __LIBBPF_BPF_H

libbpf.h uses __BPF_LIBBPF_H ... you might want to come
with some common pattern for these defines

jirka