From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752890AbbETIXf (ORCPT ); Wed, 20 May 2015 04:23:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37000 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbbETIXc (ORCPT ); Wed, 20 May 2015 04:23:32 -0400 Message-ID: <555C447C.1000003@redhat.com> Date: Wed, 20 May 2015 10:23:24 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Nicholas Krause CC: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] kernel:Make functions that have no external callers static in kvm.c References: <1432095850-24586-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1432095850-24586-1-git-send-email-xerofoify@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/05/2015 06:24, Nicholas Krause wrote: > This makes the functions kvm_guest_cpu_init and kvm_init_debugfs > static now due to having no external callers outside their > declarations in the file, kvm.c. > > Signed-off-by: Nicholas Krause > --- > arch/x86/kernel/kvm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/kvm.c b/arch/x86/kernel/kvm.c > index 9435620..cc34cec 100644 > --- a/arch/x86/kernel/kvm.c > +++ b/arch/x86/kernel/kvm.c > @@ -331,7 +331,7 @@ static void kvm_guest_apic_eoi_write(u32 reg, u32 val) > apic_write(APIC_EOI, APIC_EOI_ACK); > } > > -void kvm_guest_cpu_init(void) > +static void kvm_guest_cpu_init(void) > { > if (!kvm_para_available()) > return; > @@ -655,7 +655,7 @@ static inline void spin_time_accum_blocked(u64 start) > static struct dentry *d_spin_debug; > static struct dentry *d_kvm_debug; > > -struct dentry *kvm_init_debugfs(void) > +static struct dentry *kvm_init_debugfs(void) > { > d_kvm_debug = debugfs_create_dir("kvm-guest", NULL); > if (!d_kvm_debug) > Applied, thanks. Paolo