From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755869AbbETVDp (ORCPT <rfc822;w@1wt.eu>);
	Wed, 20 May 2015 17:03:45 -0400
Received: from terminus.zytor.com ([198.137.202.10]:39826 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755368AbbETVAC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 20 May 2015 17:00:02 -0400
Message-ID: <555CF5B7.8080709@zytor.com>
Date: Wed, 20 May 2015 13:59:35 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Andy Lutomirski <luto@amacapital.net>
CC: "H.J. Lu" <hjl.tools@gmail.com>, Borislav Petkov <bp@alien8.de>,
        Jan Beulich <JBeulich@suse.com>, Binutils <binutils@sourceware.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Avoiding unnecessary jump relocations in gas?
References: <CALCETrUXnXVARO=KD+r0YV1wi2vvXF-41VS++F877HsJs1qz9Q@mail.gmail.com> <554B6E0102000078000778D0@mail.emea.novell.com> <CAMe9rOri61BL=uUgC8FVCs0peGR=KKRh629rOsRtbzMs8N=MrA@mail.gmail.com> <CALCETrX35KY8M0JKdoF1CB853AiS8wqH2-uQ976EptU3xf3=Dg@mail.gmail.com> <CAMe9rOpOuYY0DffAd21VffSpvzvrkPe2pJxpZtEQX=Djpi_Lgw@mail.gmail.com> <CAMe9rOrA2QGEagix2PK=QwwapBWMptr4gxW8t06-HhkodBTVwA@mail.gmail.com> <CALCETrVSN7Mt_tRQ1_x=mvYD-ygoCHM+juvi80bhddaUEDDxdA@mail.gmail.com> <CAMe9rOqrdRUH9kPU6aO=fmtfdPoua319kvsZgRovEyT37kencQ@mail.gmail.com> <555A4628.4060802@zytor.com> <CAMe9rOrSP=XW29ae3fkHrFUdjhfvGbB5b5U=EA74wofNC4qEBA@mail.gmail.com> <555A4B67.4080201@zytor.com> <555A4CCC.2010102@zytor.com> <CALCETrUQ_uMLEn3O-Vmu0vOm_4qRYxgj8YZOUJE13SDMqQmBPQ@mail.gmail.com>
In-Reply-To: <CALCETrUQ_uMLEn3O-Vmu0vOm_4qRYxgj8YZOUJE13SDMqQmBPQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/20/2015 01:53 PM, Andy Lutomirski wrote:
> Egads.  Now I understand what that code is.  I don't like the balign,
> since this has nothing to do with alignment -- we're creating an array
> of functions.

Actually it does... we align to the beginning of each slot.  If .balign
could be something other than a power of 2 that would work, too.

I was mostly looking to minimize the amount of gas magic we rely on.

> Can't we make it explicit?
> 
> #define EARLY_IDT_HANDLER_STRIDE 9
> 
> ...
> 
>     .rept NUM_EXCEPTION_VECTORS
>     . = early_idt_handlers + i * EARLY_IDT_HANDLER_STRIDE
>     .if (EXCEPTION_ERRCODE_MASK >> i) & 1
>     ASM_NOP2
>     .else
>     pushl $0        # Dummy error code, to make stack frame uniform
>     .endif
>     pushl $i        # 20(%esp) Vector number
>     jmp early_idt_handler
>     i = i + 1
>     .endr
> 
> gas will error out if we try to move . backwards, so this should be safe.

If that works too with all the versions of gas we care about, that would
be fine (and I do appreciate the explicitness.)  However, .[b]align is
something that will have been well exercised in every version of gas, so
I do feel slightly safer with it.

	-hpa