From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754586AbbEUHkv (ORCPT ); Thu, 21 May 2015 03:40:51 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50677 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751629AbbEUHku (ORCPT ); Thu, 21 May 2015 03:40:50 -0400 Message-ID: <555D8C01.2050807@suse.de> Date: Thu, 21 May 2015 09:40:49 +0200 From: Hannes Reinecke User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: "H. Peter Anvin" CC: linux-kernel@vger.kernel.org, Johannes Thumshirn , Paul Bolle Subject: Re: [PATCHv2] edd: support original Phoenix EDD 3.0 information References: <1432193984-64021-1-git-send-email-hare@suse.de> In-Reply-To: <1432193984-64021-1-git-send-email-hare@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/21/2015 09:39 AM, Hannes Reinecke wrote: > The original Phoenix EDD 3.0 specification (as found in > eg http://mbldr.sourceforge.net/specsedd30.pdf) has a > device path length of 36, not 44. > All the other fields are identical, so we can trivially support > both formats. > > Cc: Paul Bolle > Signed-off-by: Hannes Reinecke > --- > drivers/firmware/edd.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/drivers/firmware/edd.c b/drivers/firmware/edd.c > index e229576..92bc0e8 100644 > --- a/drivers/firmware/edd.c > +++ b/drivers/firmware/edd.c > @@ -8,6 +8,8 @@ > * BIOS Enhanced Disk Drive Services (EDD) > * conformant to T13 Committee www.t13.org > * projects 1572D, 1484D, 1386D, 1226DT > + * and the original Phoenix BIOS EDD 3.0 spec from > + * > * > * This code takes information provided by BIOS EDD calls > * fn41 - Check Extensions Present and > @@ -545,8 +547,9 @@ edd_has_edd30(struct edd_device *edev) > } > > > - /* We support only T13 spec */ > - if (info->params.device_path_info_length != 44) > + /* We support T13 d1572 and the original Phoenix spec */ > + if (info->params.device_path_info_length != 44 && > + info->params.device_path_info_lenght != 36) > return 0; > > for (i = 30; i < info->params.device_path_info_length + 30; i++) > No for gods sake. My mailer must really hate me. Next try will follow ... Cheers, Hannes -- Dr. Hannes Reinecke zSeries & Storage hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)