From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754853AbbEUK7J (ORCPT ); Thu, 21 May 2015 06:59:09 -0400 Received: from mx-rz-2.rrze.uni-erlangen.de ([131.188.11.21]:44305 "EHLO mx-rz-2.rrze.uni-erlangen.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754118AbbEUK7G (ORCPT ); Thu, 21 May 2015 06:59:06 -0400 X-RRZE-Submit-IP: 2001:638:a000:4142::ff0f:d304 Message-ID: <555DBA77.6010503@fau.de> Date: Thu, 21 May 2015 12:59:03 +0200 From: Andreas Ruprecht User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Jaegeuk Kim CC: "Theodore Ts'o" , Uday Savagaonkar , linux-kernel , Paul Bolle , Valentin Rothberg , Stefan Hengelein Subject: Unnecessary #ifdef in commit c863114122ac Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, your commit c863114122ac ("f2fs crypto: add symlink encryption") showed up in linux-next today (i.e., next-20150521). I noticed it because we run a daily analysis on linux-next, checking for inconsistencies regarding #ifdef blocks [0,1]. In the commit, you create nested #ifdef blocks like the following: #ifdef CONFIG_F2FS_FS_ENCRYPTION [...] #ifdef CONFIG_F2FS_FS_XATTR [...] #endif [...] #endif The inner #ifdef, however, is unnecessary as CONFIG_F2FS_FS_XATTR is defined with a dependency on CONFIG_F2FS_FS_ENCRYPTION (line 78 in the corresponding Kconfig file at fs/f2fs/Kconfig). This means, CONFIG_F2FS_FS_XATTR can never be disabled if CONFIG_F2FS_FS_ENCRYPTION is enabled, and that the inner #ifdef can safely be removed. Do you want me to send a patch for this or do you want to do this yourself? Best regards, Andreas [0] https://cados.cs.fau.de [1] http://www.linuxplumbersconf.org/2014/ocw/proposals/1863