Re: [PATCH 0/5] Marvell PXA1928 USB support

Sebastian Hesselbarth
2015-05-15T09:55:58Z

On 14.05.2015 00:48, Rob Herring wrote:
> This series adds USB PHYs and EHCI host drivers for the Marvell PXA1928
> SOC.
>
> The OTG block is based on ChipIdea and works with "chipidea,usb2"
> compatible driver as is just by adding the PHY driver. Yay!
>
> Rob
>
> Rob Herring (5):
> dt-bindings: Add Marvell PXA1928 USB and HSIC PHY bindings
> dt-bindings: Add Marvell PXA1928 USB EHCI controller binding
> phy: Add Marvell USB 2.0 OTG 28nm PHY
> phy: add Marvell HSIC 28nm PHY
> usb: add pxa1928 ehci support
>
> .../devicetree/bindings/phy/pxa1928-usb-phy.txt | 18 ++
> .../devicetree/bindings/usb/ehci-pxa1928.txt | 19 ++
> drivers/phy/Kconfig | 20 ++
> drivers/phy/Makefile | 2 +
> drivers/phy/phy-mv-hsic.c | 208 +++++++++++++
> drivers/phy/phy-mv-usb2.c | 329 +++++++++++++++++++++

[Adding some MVEBU guys]

Rob,

I had a look at the USB PHYs of some of the other Marvell SoCs a while
ago for the barebox bootloader [1]. Marvell seems to distinguish the
USB PHY type by technology node, e.g. 28nm like the one above. For the
most used Marvell SoCs, i.e. Kirkwood, Dove, and Armada 370/XP, they all
use a different technology node and we could either use the SoC name
or the technology node as compatible.

Anyway, if you are introducing new PHY drivers with _that_ generic
names, it will either clash with every other Marvell USB PHYs -
or we'll have to add the PHY code into the drivers above.

[1] http://lists.infradead.org/pipermail/barebox/2014-June/019600.html

> drivers/usb/host/Kconfig | 15 +-
> drivers/usb/host/Makefile | 1 +
> drivers/usb/host/ehci-mv-of.c | 243 +++++++++++++++
> 9 files changed, 854 insertions(+), 1 deletion(-)
> create mode 100644 Documentation/devicetree/bindings/phy/pxa1928-usb-phy.txt
> create mode 100644 Documentation/devicetree/bindings/usb/ehci-pxa1928.txt
> create mode 100644 drivers/phy/phy-mv-hsic.c
> create mode 100644 drivers/phy/phy-mv-usb2.c
> create mode 100644 drivers/usb/host/ehci-mv-of.c
>