Re: [PATCH 0/5] Marvell PXA1928 USB support

Arnd Bergmann
2015-05-15T14:12:05Z

On Friday 15 May 2015 07:48:24 Rob Herring wrote:
>
> > Anyway, if you are introducing new PHY drivers with _that_ generic
> > names, it will either clash with every other Marvell USB PHYs -
> > or we'll have to add the PHY code into the drivers above.
>
> How about phy-pxa-28nm-{usb2,hsic}?
>

Seems ok to me, but please verify that these are actually usb2 and hsic
specific devices. There are a lot of PHY implementations that share the
basic layout between devices for different purposes, e.g. USB3 and PCIe
and they should have a name that is not too specific for one connection
when the same driver gets reused by another part.

Arnd