From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755218AbbEVC2i (ORCPT ); Thu, 21 May 2015 22:28:38 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:56084 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752558AbbEVC2g (ORCPT ); Thu, 21 May 2015 22:28:36 -0400 X-AuditID: cbfee691-f79ca6d00000456a-03-555e9451da44 Message-id: <555E9451.2010504@samsung.com> Date: Fri, 22 May 2015 11:28:33 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Arnd Bergmann Cc: Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, MyungJoo Ham , Krzysztof Kozlowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] extcon: fix phy-tahvo driver for extcon API change References: <4940971.fmN098LqHi@wuerfel> In-reply-to: <4940971.fmN098LqHi@wuerfel> Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrJIsWRmVeSWpSXmKPExsWyRsSkUDdwSlyoweFJphZ/Jx1jtzh4v96i efF6NovXLwwtNj2+xmpxedccNotFy1qZLW43rmBz4PD4/WsSo8f+uWvYPTYvqffo27KK0eP4 je1MHp83yQWwRXHZpKTmZJalFunbJXBlrD7xg7FgO0/F0Q+d7A2MbVxdjJwcEgImEuvWLWKH sMUkLtxbz9bFyMUhJLCUUWJz3xdmmKLu+QvYIRKLGCW+Pl3KCpIQEnjAKNG50hnE5hXQkpi1 rIupi5GDg0VAVeJOFy9ImA0ovP/FDTYQW1QgTGLl9CssEOWCEj8m3wOzRQQUJaa+eAa2i1mg n0ni7qYaEFtYwF3iRNs8dohVGhKfru0Dq+cU0JT4f2gPI0S9lsT6nceZIGx5ic1r3jKD3Ckh cI1d4krzT7DFLAICEt8mH2IBuU1CQFZi0wGovyQlDq64wTKBUWwWkpNmIRk7C8nYBYzMqxhF UwuSC4qT0otM9YoTc4tL89L1kvNzNzECY/D0v2cTdzDeP2B9iFGAg1GJh5dDPTZUiDWxrLgy 9xCjKdAVE5mlRJPzgZGeVxJvaGxmZGFqYmpsZG5ppiTOqyP9M1hIID2xJDU7NbUgtSi+qDQn tfgQIxMHp1QD43pbAb2OtO6ExSf1dH7x5Hn6TfyT6HutxWL6pLnpaz3eNHYy5nG+kRBYc/DH 4XlCt9hSKtLvPDB/GR7r1RL1qNx17qFWV5Ov/XcU1Vep8h2/6/BOOWtX5uFrDgETHMpuu7Az T7I51rLX+H9f/v5Zhi/vr+QU2pdSabD05MZ7IuLftj+/uGb5ZSWW4oxEQy3mouJEABGxwCu8 AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jAd3AKXGhBtv6DSz+TjrGbnHwfr1F 8+L1bBavXxhabHp8jdXi8q45bBaLlrUyW9xuXMHmwOHx+9ckRo/9c9ewe2xeUu/Rt2UVo8fx G9uZPD5vkgtgi2pgtMlITUxJLVJIzUvOT8nMS7dV8g6Od443NTMw1DW0tDBXUshLzE21VXLx CdB1y8wBOkdJoSwxpxQoFJBYXKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmLH6xA/Ggu08 FUc/dLI3MLZxdTFyckgImEh0z1/ADmGLSVy4t56ti5GLQ0hgEaPE16dLWUESQgIPGCU6VzqD 2LwCWhKzlnUxdTFycLAIqErc6eIFCbMBhfe/uMEGYosKhEmsnH6FBaJcUOLH5HtgtoiAosTU F8+YQWxmgX4mibubakBsYQF3iRNt89ghVmlIfLq2D6yeU0BT4v+hPYwQ9VoS63ceZ4Kw5SU2 r3nLPIFRYBaSFbOQlM1CUraAkXkVo2hqQXJBcVJ6rqFecWJucWleul5yfu4mRnCEP5Pawbiy weIQowAHoxIPL4d6bKgQa2JZcWXuIUYJDmYlEV69+rhQId6UxMqq1KL8+KLSnNTiQ4ymwACY yCwlmpwPTD55JfGGxiZmRpZG5oYWRsbmSuK8J/N9QoUE0hNLUrNTUwtSi2D6mDg4pRoYN626 eM1dXU3jz+OVi7eFqN86+G87z9bGzbJTmnZtfP5YVM8+ncFl4mPGSpmH0mEhHGl1XCpGpZcS 2hZH6nBtzWB2/+9WL7onVCynaemOfkapE3yy8q6Ndewsur6eSrope8tuX4/V41E3+mwbb+sz Iz16jud5satyc9/k/b4aHan7comTc6QSS3FGoqEWc1FxIgDqJ9dPBgMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dear Felipe, If you review this patch, I'll apply it on extcon tree. Best Regards, Chanwoo Choi On 05/21/2015 06:39 PM, Arnd Bergmann wrote: > Today, the API for the extcon drivers was changed, along > with all drivers in drivers/extcon. However, one extcon driver > instead lives in drivers/usb/phy/ and did not get change. > > Gcc warns about the now incorrect API usage: > > drivers/usb/phy/phy-tahvo.c: In function 'tahvo_usb_probe': > drivers/usb/phy/phy-tahvo.c:368:29: warning: assignment from incompatible pointer type [-Wincompatible-pointer-types] > tu->extcon.supported_cable = tahvo_cable; > > This changes the API in the same way as the other drivers. > > Signed-off-by: Arnd Bergmann > Fixes: 17cd440c9acc ("extcon: Update the prototype of extcon_register_notifier() with enum extcon") > --- > As the API change is only present in the extcon tree, this patch should get > merged there as well, not in the usb-phy tree. > > If possible, please fold into the original commit. > > diff --git a/drivers/usb/phy/phy-tahvo.c b/drivers/usb/phy/phy-tahvo.c > index 845f658276b1..1d1bb9ad8ccf 100644 > --- a/drivers/usb/phy/phy-tahvo.c > +++ b/drivers/usb/phy/phy-tahvo.c > @@ -60,10 +60,11 @@ struct tahvo_usb { > struct extcon_dev extcon; > }; > > -static const char *tahvo_cable[] = { > - "USB-HOST", > - "USB", > - NULL, > +static const enum extcon tahvo_cable[] = { > + EXTCON_USB, > + EXTCON_USB_HOST, > + > + EXTCON_NONE, > }; > > static ssize_t vbus_state_show(struct device *device, > >