From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
yrl.pp-manager.tt@hitachi.com,
Aaron Fabbri <aaronx.j.fabbri@intel.com>,
linux-kernel@vger.kernel.org, Divya Vyas <edivya.vyas@gmail.com>
Subject: Re: [PATCH trace-cmd V5 2/6] trace-cmd/listen: Introduce trace-msg protocol (protocol v2)
Date: Fri, 22 May 2015 13:53:01 +0900 [thread overview]
Message-ID: <555EB62D.4070008@hitachi.com> (raw)
In-Reply-To: <20150519231202.35614532@grimm.local.home>
Hi Steven,
On 2015/05/20 12:12, Steven Rostedt wrote:
> On Mon, 22 Dec 2014 12:47:50 -0500
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
>
>> Introduce new trace-msg protocol (protocol V2) for more
>> flexible messaging. V1 protocol which is currently used
>> by trace-cmd server and client, is based on a simple
>> text messages. It is impossible to extend the protocol
>> without breaking backward compatibility. The V2 protocol
>> introduced by this patch is a binary message-based protocol
>> and it is able to extend by just adding message tags.
>>
>> <How to test>
>> [1] Backward compatibility checks
>> We need to test backward compatibility of this patch for old
>> trace-cmds(client/server). So, this patch was tested for [2]
>> command checks in following 3 types:
>>
>> <client> <server>
>> new old
>> old new
>> new new
>>
>> [2] Command checks
>> - server (common)
>> # trace-cmd listen -p 12345
>>
>> 1) record
>> - client
>> # trace-cmd record -e sched -N <server IP>:12345
>> ^C
>>
>> 2) record + multiple buffers
>> - client
>> # trace-cmd record -B foo -e sched -N <server IP>:12345
>> ^C
>>
>> 3) extract
>> - client
>> # ./trace-cmd start -e sched
>> # sleep 5
>> # ./trace-cmd stop
>> # ./trace-cmd extract -N <server IP>:12345
>>
>> 4) extract + snapshot
>> - client
>> # ./trace-cmd start -e sched
>> # sleep 5
>> # ./trace-cmd snapshot -s
>> # ./trace-cmd stop
>> # ./trace-cmd extract -N <server IP>:12345 -s
>>
>> Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
>>
>
> Hi Masami,
>
> Is this a rewrite of Yoshihiro's work? I would like to keep the From:
> from him if he did the initial work, and add both of your
> signed-off-bys.
OK, but actually he left Hitachi, so his e-mail address is invalid...
Is that OK to use that old email address?
> Note, I did pull in some of his patches to a temp branch and extended
> on them. I'll look to see if I have to modify this code as well.
OK, thanks!
>
> Thanks!
>
> -- Steve
>
>
--
Masami HIRAMATSU
Linux Technology Research Center, System Productivity Research Dept.
Center for Technology Innovation - Systems Engineering
Hitachi, Ltd., Research & Development Group
E-mail: masami.hiramatsu.pt@hitachi.com
next prev parent reply other threads:[~2015-05-22 4:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 17:47 [PATCH trace-cmd V5 0/6] perf-probe: Bugfix and add new options for cache Masami Hiramatsu
2014-12-22 16:45 ` Steven Rostedt
2014-12-24 1:13 ` Masami Hiramatsu
2014-12-22 17:47 ` [PATCH trace-cmd V5 1/6] trace-cmd: Support -N option for trace-cmd extract Masami Hiramatsu
2014-12-22 17:47 ` [PATCH trace-cmd V5 2/6] trace-cmd/listen: Introduce trace-msg protocol (protocol v2) Masami Hiramatsu
2015-05-20 3:12 ` Steven Rostedt
2015-05-22 4:53 ` Masami Hiramatsu [this message]
2015-05-22 9:14 ` Steven Rostedt
2015-05-24 1:59 ` Masami Hiramatsu
2014-12-22 17:47 ` [PATCH trace-cmd V5 3/6] trace-cmd/msg: Use poll(2) to wait for a message Masami Hiramatsu
2014-12-22 17:48 ` [PATCH trace-cmd V5 4/6] trace-cmd/virt-server: Add virt-server mode for a virtualization environment Masami Hiramatsu
2014-12-22 17:48 ` [PATCH trace-cmd V5 5/6] trace-cmd/record: Add --virt option for record mode Masami Hiramatsu
2014-12-22 17:48 ` [PATCH trace-cmd V5 6/6] trace-cmd/virt-server: Add --dom option which makes a domain directory to virt-server Masami Hiramatsu
2015-05-19 21:06 ` [PATCH trace-cmd V5 0/6] perf-probe: Bugfix and add new options for cache Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555EB62D.4070008@hitachi.com \
--to=masami.hiramatsu.pt@hitachi.com \
--cc=aaronx.j.fabbri@intel.com \
--cc=edivya.vyas@gmail.com \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox