From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755819AbbEVFoA (ORCPT ); Fri, 22 May 2015 01:44:00 -0400 Received: from mail-bl2on0062.outbound.protection.outlook.com ([65.55.169.62]:40590 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751161AbbEVFn7 (ORCPT ); Fri, 22 May 2015 01:43:59 -0400 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; ettus.com; dkim=none (message not signed) header.d=none; Message-ID: <555EC20C.6010703@xilinx.com> Date: Fri, 22 May 2015 07:43:40 +0200 From: Michal Simek User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Moritz Fischer , CC: , , , , , , , , , , , , , , , Subject: Re: [PATCH 2/3] dts: Adding docs for Xilinx LogiCORE IP mailbox driver. References: <1432251450-26352-1-git-send-email-moritz.fischer@ettus.com> <1432251450-26352-3-git-send-email-moritz.fischer@ettus.com> In-Reply-To: <1432251450-26352-3-git-send-email-moritz.fischer@ettus.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.0.0.1202-21558.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11FD051;1:vdWwStwaHOGe2xEashZ5dlHfHzIX4VYd7sr22yGVGXZmayrLUNUALHK0Y1GJh+H+2R2liP3ZVo+0M/TLmXrKJoQ7zR+Q7F/UU+qB/36DKfq5MtAn5lBcG8cwLNuuXThwJYmZ5ldDbnFA4riFdV0gbzCOf26rMr/UKa1ZT/XBzaRI2H5vAQnSNObtrJNEO0qT2f5zq/D25liZkDKPXLJs8F33EwkXLAZqLmU+Kcm3BwdI5VxepSaH+BQEKCtwOGISvV1/YLbWyPWLcK31cw5liQ== X-Forefront-Antispam-Report: CIP:149.199.60.83;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(438002)(164054003)(51704005)(377454003)(199003)(479174004)(189002)(24454002)(63266004)(6806004)(106466001)(50466002)(65816999)(19580395003)(19580405001)(87936001)(76176999)(23746002)(80316001)(54356999)(65956001)(64706001)(65806001)(50986999)(87266999)(83506001)(47776003)(86362001)(189998001)(5001860100001)(62966003)(5001830100001)(77156002)(5001960100002)(5001920100001)(92566002)(36756003)(59896002)(2950100001)(64126003)(46102003)(5001770100001)(81156007)(4001350100001)(4001540100001)(33656002)(77096005)(36386004)(107986001);DIR:OUT;SFP:1101;SCL:1;SRVR:BY2FFO11HUB055;H:xsj-pvapsmtpgw01;FPR:;SPF:Pass;PTR:unknown-60-83.xilinx.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB055;2:LhHc6IP4Wl76ijTPHkGRhdf7eIU4aNionB6/zD5ZbljIApCP+TpSyHLw/X3QFBsm;2:C3VJj3/SyD8/km0tivtOcmzl9qvcLAoHye18P5cDRQproY1XOgVNSqtSxVlDf8G5r9HLoYRT0qlclXJm3uNf/j4xUflEAeCCsjsHkMqMjjlFU7WLOw1NfhREg05z8mPgfQH+5n245m1gdDfTxLtvM02XRIL1SILPQyRPB5XCyvKyehWniup49O0JNlwMmL9oZk50P8g/L8k0Qa1o+ZeyvhwPqVMdJpqRqAylTvOSVJo=;6:4TJ5EKFckAlazeQ7GT+GgZG4Z3EoeT5Mr/7eGcuWVxMHLiOmPrC/J+2Wtvw/9BqqsJr31FctvKZ1EKN9Oe24Ltc2/RXaaIQjbCyinxaaD57BHQ7JeKB/3SXRUTR+xXaQRhQOvAVmxZIFjbIxzoqvUs3eeQQRl8ColnLgjTWj0ihxCDMWrCjGgpFIY+nERkuFn91gaoXJSFfezibth6DVekNjMjc3NNqx8fAj3BgN+/rlzbMWZ4uyMo5lHSsuz5OWNPGF6Yp+tLMXB+0TpMmiEaOghL0lYOTUfXg7FiT8JN12BdavCd7Y30Wn2B99eX+3Rr13chTJbFWUeuQIPaZlRxVw0/ppblfIAPzw98bmJO/g3RCNmfpySCTxHxI0kktD8kkbrJewJxZMxjcOzY7uKJUQ8W6mPQ6RX5XGKlEQNA+ZvVcqZJ0eU67ZNWpaid9WJammyqdkyD8G8PJPgxSgebiH6/xubdXCe9g/mtt5l9wCZnjz5PIDX6rcnfLBsSnz X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB055; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(520002)(5005006)(3002001);SRVR:BY2FFO11HUB055;BCL:0;PCL:0;RULEID:;SRVR:BY2FFO11HUB055; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB055;3:l2v29azec3TjKXHYExUT/rYf2A43u3xxWJ+A3Pfqjkw3Scil+rveL0E3VLyyuy1wF155711zTQV+HoHoy/9QOVvSPYMVYtc5FEPLMUWtL55o5Wtf1UU++u+N2KPxuylBoZmN+slbfiq7O0HQqEVSbCE1dxrAtUwehrs6Ya27vZLCa2gf6A86xU0EYBWhhk1l+BhXR6qnWTUX8EdjHCmIJxn09iLwVBTjezN3GzC7ks/if48AVPYfsBt5O4mH4/giLg9vCz29tv2j6PQ8YUFd/zAPWPcvFzm4UYonS+RgFiBuADnmuKZeKmXy3obc+QYt X-Forefront-PRVS: 058441C12A X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;BY2FFO11HUB055;9:aVO8QkMSE5z7B/x/SCsmToZiJSz7PcH226j0r?= =?Windows-1252?Q?7TPOibZXY7/JrLPhBsiC96iRDXrqapJ9jzJiC9eX18U2em5qkMIvDX6C?= =?Windows-1252?Q?j2BqCHRuXbrvaK3vfnDhmz6ytM38zw4fS6jBr56djhCtijrRCOECtNGg?= =?Windows-1252?Q?3GMqWPrx9JhVpI8wx/lVX5ayETdAUuhT9WxbCFGzYrfAtWsWV7m9B9PR?= =?Windows-1252?Q?etWvQn1Cry0Q50ewJMPZif86I9EwopMn7XGsJoaBwnBDfAmi36YJlcaK?= =?Windows-1252?Q?GzqVi1Sw8a2D/u7maFFNZPbN5z1DqGIrmlSejbj9Hsbx+YVHPfGvSv8Y?= =?Windows-1252?Q?FDUvCzYxtf+BTZp/NFmAqYM8EPe6BSNMzzq3uWgbwzcOgDTYU/slu+mV?= =?Windows-1252?Q?t3pnN8r+0EKoblRJgS9CJb3Zi7KUbGGap0EnIiXsP0lR099ltZ6TyttX?= =?Windows-1252?Q?VmwPyXR2C8sADyh8zyBY/gbS5yj6e5TjLW74OSMnzzk+5xqbHvxrOifR?= =?Windows-1252?Q?p0PSlZZz4lWh+Bkggmrcpior5H4ZbuXR40er7vEwcLzNwPyv7+zteDYH?= =?Windows-1252?Q?ut/2FnC42d1+NPzxP+zm1yhh/+UJIMJHvng1AxU+ZjHkbS1r+nYuK+hk?= =?Windows-1252?Q?fhC1TVJbcT8kDZLdA9jWWfT1UJAyiMzy1/xKovpO56ZEzTsjvBPiynTe?= =?Windows-1252?Q?ex0s8SfmLovQV4ZkTI/3RFCAVcXNympX0vKMd/EKXvcj3iDlaQu3vuje?= =?Windows-1252?Q?/FmphDA3g0Lvhb37ji7pPs1cArmirdw7Cz/00XqR/mGpg14jqGen/t96?= =?Windows-1252?Q?+oPnqusk7Vm4QtK8xFeyilT5Xfa7z9LAlyfj6yb+0wEusANPNbjRmNwr?= =?Windows-1252?Q?PzQBX3JOFkY7bQm0F1AH6AzzRjEiLBOdy4aKS1LaDNdbX4bxo7MQPwN0?= =?Windows-1252?Q?eCv8jDPl5+Oal7qfD2CJlFu+BO0Rxr/kwu6XU+S3KIZ+3CmcjJRL6zfr?= =?Windows-1252?Q?4CTG4NirqIg1MWwr8wQp45/Q2YBWVaArkpUjYTrIn5DD3sJUb+fIhRfF?= =?Windows-1252?Q?QE4U0x42MKDMDbDAaq9ga0/9F9R27oH+ucTvWHldjSeDIALPqxxarTWO?= =?Windows-1252?Q?R6lItaI4rL2lg3TkmP32ksWcye6wwBEVnxDQIQcuX/9eHCgQgYnEw588?= =?Windows-1252?Q?WG2yJt21BDUABSaz+sqy/g1epNSdyNPLmfCBVK3ARYKNFfqFRyO/6MhY?= =?Windows-1252?Q?ed0ze8U5CFJNeYvrWsdF3W1ptuIeuEoCKboCQkijSrsqgDeKNyIWfXfQ?= =?Windows-1252?Q?TcgOsiyi4ChQJrbwcENcF3TRJ/gebc2pyST9cas9AzX35iyC5s1TFWyC?= =?Windows-1252?Q?ImaSKtRxs/ukV80dsb11NkV9jY2UoVAgtDxG54StJIT0u6oZGwf6l0?= =?Windows-1252?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11HUB055;3:P48BwtUY3FvMNRkQZYF9pGhquMFZNM14Yg6ThvIIq9WUM3zJrUCQOh/IDfEDOUp6SUSIwHC5+AcpUi7uvk5VBlEXqq3VFXEdMTDmAl7dlU5GaadhfSRIPWc7vS9HmDKvrmSEgOL0IH4Mqzm/y+RiXw==;10:dFY8PwB5oUFjcJa3AxOAd5uP1kvzsL0oKZVViF7vpg4BXRZBScs8gABLfTNCnVzI9eYuksO3fuAyWk/Qlc4CORrAH8evIf6MgQNjsVp5UmA= X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2015 05:43:54.5270 (UTC) X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c;Ip=[149.199.60.83];Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2FFO11HUB055 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/22/2015 01:37 AM, Moritz Fischer wrote: > Signed-off-by: Moritz Fischer > --- > .../bindings/mailbox/xilinx-mailbox.txt | 40 ++++++++++++++++++++ > 1 file changed, 40 insertions(+) > IRC the rule was to send binding first and then the driver. > diff --git a/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > new file mode 100644 > index 0000000..e559743 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mailbox/xilinx-mailbox.txt > @@ -0,0 +1,40 @@ > +Xilinx Mailbox Driver > +===================== > + > +Required properties: > +- compatible : "xlnx,mailbox-2.1". > +- reg : physical base address of the mailbox and length of > + memory mapped region. > +- #mbox-cells: Common mailbox binding property to identify the number > + of cells required for the mailbox specifier. Should be 1. > + > +Optional properties: > +- interrupt-parent : interrupt source phandle. > +- interrupts : interrupt number. The interrupt specifier format please be consistent with spacing around :. It doesn't look nice. > + depends on the interrupt controller parent. > + > +Example: > + mbox: mailbox@0x40400000 { remove 0x prefix here. > + compatible = "xlnx,axi-mailbox-2.1"; > + reg = <0x100 0x3c>; This is weird - it should start with 40400000. Or is your physical address 0x100? > + interrupt-parent = <&intc>; > + interrupts = <5>; > + #mbox-cells = <1>; > + }; > + > +Mailbox client > +=============== > +"mboxes" and the optional "mbox-names" (please see > +Documentation/devicetree/bindings/mailbox/mailbox.txt for details). Each value > +of the mboxes property should contain a phandle to the mailbox controller > +device node and second argument is the channel index. It must be 0 (hardware > +support only one channel).The equivalent "mbox-names" property value can be .The > +used to give a name to the communication channel to be used by the client user. > + > +Example: > + mclient0: mclient0@0x400 { ditto. > + compatible = "client-1.0"; > + reg = <0x400 0x10>; > + mbox-names = "mbox", "mbox-rx"; > + mboxes = <&mbox 0>; > + }; > Thanks, Michal