public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel:signal - Fix for typos in comments.
@ 2015-05-23  5:09 Shailendra Verma
  2015-05-23  9:15 ` Richard Weinberger
  2015-05-23 17:15 ` Pranith Kumar
  0 siblings, 2 replies; 3+ messages in thread
From: Shailendra Verma @ 2015-05-23  5:09 UTC (permalink / raw)
  To: Oleg Nesterov, Andrew Morton, Richard Weinberger,
	Paul E. McKenney, Pranith Kumar, Vladimir Davydov
  Cc: linux-kernel, Shailendra Verma


Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
---
 kernel/signal.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/signal.c b/kernel/signal.c
index d51c5dd..5c65e7c 100644
--- a/kernel/signal.c
+++ b/kernel/signal.c
@@ -342,7 +342,7 @@ static bool task_participate_group_stop(struct task_struct *task)
 		sig->group_stop_count--;
 
 	/*
-	 * Tell the caller to notify completion iff we are entering into a
+	 * Tell the caller to notify completion if we are entering into a
 	 * fresh group stop.  Read comment in do_signal_stop() for details.
 	 */
 	if (!sig->group_stop_count && !(sig->flags & SIGNAL_STOP_STOPPED)) {
@@ -1864,7 +1864,7 @@ static void ptrace_stop(int exit_code, int why, int clear_code, siginfo_t *info)
 
 	/*
 	 * If @why is CLD_STOPPED, we're trapping to participate in a group
-	 * stop.  Do the bookkeeping.  Note that if SIGCONT was delievered
+	 * stop.  Do the bookkeeping.  Note that if SIGCONT was delivered
 	 * across siglock relocks since INTERRUPT was scheduled, PENDING
 	 * could be clear now.  We act as if SIGCONT is received after
 	 * TASK_TRACED is entered - ignore it.
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] kernel:signal - Fix for typos in comments.
  2015-05-23  5:09 [PATCH] kernel:signal - Fix for typos in comments Shailendra Verma
@ 2015-05-23  9:15 ` Richard Weinberger
  2015-05-23 17:15 ` Pranith Kumar
  1 sibling, 0 replies; 3+ messages in thread
From: Richard Weinberger @ 2015-05-23  9:15 UTC (permalink / raw)
  To: Shailendra Verma, Oleg Nesterov, Andrew Morton, Paul E. McKenney,
	Pranith Kumar, Vladimir Davydov
  Cc: linux-kernel

Am 23.05.2015 um 07:09 schrieb Shailendra Verma:
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  kernel/signal.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/signal.c b/kernel/signal.c
> index d51c5dd..5c65e7c 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -342,7 +342,7 @@ static bool task_participate_group_stop(struct task_struct *task)
>  		sig->group_stop_count--;
>  
>  	/*
> -	 * Tell the caller to notify completion iff we are entering into a

http://en.wikipedia.org/wiki/If_and_only_if

Thanks,
//richard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] kernel:signal - Fix for typos in comments.
  2015-05-23  5:09 [PATCH] kernel:signal - Fix for typos in comments Shailendra Verma
  2015-05-23  9:15 ` Richard Weinberger
@ 2015-05-23 17:15 ` Pranith Kumar
  1 sibling, 0 replies; 3+ messages in thread
From: Pranith Kumar @ 2015-05-23 17:15 UTC (permalink / raw)
  To: Shailendra Verma
  Cc: Oleg Nesterov, Andrew Morton, Richard Weinberger,
	Paul E. McKenney, Vladimir Davydov, LKML

On Sat, May 23, 2015 at 1:09 AM, Shailendra Verma wrote:

Please include a changelog for every patch you submit exolaining why
you think the change makes sense.

>
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  kernel/signal.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/signal.c b/kernel/signal.c
> index d51c5dd..5c65e7c 100644
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -342,7 +342,7 @@ static bool task_participate_group_stop(struct task_struct *task)
>                 sig->group_stop_count--;
>
>         /*
> -        * Tell the caller to notify completion iff we are entering into a
> +        * Tell the caller to notify completion if we are entering into a

iff means "if and only if" and I think it makes perfect sense here. I
encourage you to keep trying :)

Thanks!
-- 
Pranith

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-05-23 17:15 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-23  5:09 [PATCH] kernel:signal - Fix for typos in comments Shailendra Verma
2015-05-23  9:15 ` Richard Weinberger
2015-05-23 17:15 ` Pranith Kumar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox