From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Chen-Yu Tsai <wens@csie.org>,
Samuel Holland <samuel@sholland.org>,
Icenowy Zheng <uwu@icenowy.me>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
Icenowy Zheng <uwu@icenowy.me>
Subject: Re: [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical
Date: Sun, 24 Apr 2022 21:55:17 +0200 [thread overview]
Message-ID: <5560593.DvuYhMxLoT@kista> (raw)
In-Reply-To: <20220424055959.109286-1-uwu@icenowy.me>
Dne nedelja, 24. april 2022 ob 07:59:59 CEST je Icenowy Zheng napisal(a):
> RTC itself is the one and only consumer of rtc-32k clock. As the rtc
> should be always running, set rtc-32k clock to critical, to prevent it
> from being gated by the kernel.
>
> Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks")
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
This one was already submitted here:
https://lore.kernel.org/linux-sunxi/20220411050100.40964-1-samuel@sholland.org/
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-
sun6i-rtc.c
> index 8a10bade7e0d..3d9c9ce5a3db 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> @@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = {
> .ops = &ccu_mux_ops,
> .parent_hws = rtc_32k_parents,
> .num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated
during probe */
> + .flags = CLK_IS_CRITICAL,
> };
>
> static struct ccu_mux rtc_32k_clk = {
> --
> 2.35.1
>
>
>
prev parent reply other threads:[~2022-04-24 19:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-24 5:59 [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical Icenowy Zheng
2022-04-24 19:55 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5560593.DvuYhMxLoT@kista \
--to=jernej.skrabec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=uwu@icenowy.me \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox