From: Corentin LABBE <clabbe.montjoie@gmail.com>
To: herbert@gondor.apana.org.au
Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
maxime.ripard@free-electrons.com, linux@arm.linux.org.uk,
davem@davemloft.net, akpm@linux-foundation.org,
gregkh@linuxfoundation.org, mchehab@osg.samsung.com,
joe@perches.com, tj@kernel.org, arnd@arndb.de,
boris.brezillon@free-electrons.com, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] Re: [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator
Date: Sat, 23 May 2015 14:18:06 +0200 [thread overview]
Message-ID: <55606FFE.4000902@gmail.com> (raw)
In-Reply-To: <20150515064932.GB16704@gondor.apana.org.au>
Le 15/05/2015 08:49, Herbert Xu a écrit :
> On Thu, May 14, 2015 at 02:59:01PM +0200, LABBE Corentin wrote:
>>
>> + err = crypto_ablkcipher_setkey(op->fallback, kkey, op->keylen);
>> + if (err != 0) {
>> + dev_err(ss->dev, "Cannot set key on fallback\n");
>> + return -EINVAL;
>> + }
>
> You cannot call setkey from an atomic context. The easiest solution
> is to call setkey in your setkey function instead.
>
> Cheers,
>
Fixed
What do you think about adding a BUG_ON(in_atomic()) in crypto_ablkcipher_setkey() ?
Thanks
next prev parent reply other threads:[~2015-05-23 12:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-14 12:58 [PATCH v9] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2015-05-14 12:58 ` [PATCH v9 1/4] ARM: sun7i: dt: Add Security System to A20 SoC DTS LABBE Corentin
2015-05-15 7:31 ` Maxime Ripard
2015-05-23 12:08 ` Corentin LABBE
2015-05-14 12:58 ` [PATCH v9 2/4] ARM: sun4i: dt: Add DT bindings documentation for SUN4I Security System LABBE Corentin
2015-05-14 12:59 ` [PATCH v9 3/4] MAINTAINERS: Add myself as maintainer of Allwinner " LABBE Corentin
2015-05-14 12:59 ` [PATCH v9 4/4] crypto: Add Allwinner Security System crypto accelerator LABBE Corentin
2015-05-15 6:49 ` Herbert Xu
2015-05-23 12:18 ` Corentin LABBE [this message]
2015-05-24 3:30 ` [linux-sunxi] " Herbert Xu
2015-05-15 6:52 ` Herbert Xu
2015-05-16 18:09 ` [linux-sunxi] " Corentin LABBE
2015-05-17 1:32 ` Herbert Xu
2015-05-17 8:45 ` Boris Brezillon
2015-05-17 10:34 ` Herbert Xu
2015-05-17 10:48 ` Boris Brezillon
2015-05-18 0:41 ` Herbert Xu
2015-05-18 7:24 ` Boris Brezillon
2015-05-18 8:33 ` Herbert Xu
2015-05-23 13:12 ` Corentin LABBE
2015-05-23 14:35 ` Boris Brezillon
2015-05-24 3:32 ` Herbert Xu
2015-05-24 8:04 ` [linux-sunxi] " Corentin LABBE
2015-05-24 8:12 ` Herbert Xu
2015-06-03 19:06 ` Corentin LABBE
2015-05-17 7:45 ` [PATCH v9] " Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55606FFE.4000902@gmail.com \
--to=clabbe.montjoie@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=ijc+devicetree@hellion.org.uk \
--cc=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=mchehab@osg.samsung.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox