From: tolga ceylan <tolga.ceylan@gmail.com>
To: Benjamin Romer <benjamin.romer@unisys.com>,
David Kershner <david.kershner@unisys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jes Sorensen <Jes.Sorensen@redhat.com>,
sparmaintainer@unisys.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static
Date: Sat, 23 May 2015 19:54:27 -0700 [thread overview]
Message-ID: <55613D63.9070505@gmail.com> (raw)
In-Reply-To: <1431750141-5660-1-git-send-email-tolga.ceylan@gmail.com>
On 05/15/2015 09:22 PM, Tolga Ceylan wrote:
> visorchipset_file_init() and visorchipset_file_cleanup() functions
> do not seem to be used from anywhere else and now are declared
> as static. Sparse emitted "not declared" warnings for these two
> functions.
>
> Signed-off-by: Tolga Ceylan <tolga.ceylan@gmail.com>
> ---
> drivers/staging/unisys/visorbus/visorchipset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/unisys/visorbus/visorchipset.c b/drivers/staging/unisys/visorbus/visorchipset.c
> index ca22f49..66ae3d0 100644
> --- a/drivers/staging/unisys/visorbus/visorchipset.c
> +++ b/drivers/staging/unisys/visorbus/visorchipset.c
> @@ -2351,7 +2351,7 @@ static const struct file_operations visorchipset_fops = {
> .mmap = visorchipset_mmap,
> };
>
> -int
> +static int
> visorchipset_file_init(dev_t major_dev, struct visorchannel **controlvm_channel)
> {
> int rc = 0;
> @@ -2460,7 +2460,7 @@ cleanup:
> return rc;
> }
>
> -void
> +static void
> visorchipset_file_cleanup(dev_t major_dev)
> {
> if (file_cdev.ops)
>
I haven't received a response for this patch. Just checking back.
Regards,
Tolga Ceylan
next prev parent reply other threads:[~2015-05-24 2:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-16 4:22 [PATCH 1/1] drivers: staging: unisys: visorbus: visorchipset.c: private functions should be declared static Tolga Ceylan
2015-05-24 2:54 ` tolga ceylan [this message]
2015-05-24 14:30 ` Jes Sorensen
2015-05-24 20:32 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55613D63.9070505@gmail.com \
--to=tolga.ceylan@gmail.com \
--cc=Jes.Sorensen@redhat.com \
--cc=benjamin.romer@unisys.com \
--cc=david.kershner@unisys.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sparmaintainer@unisys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox