From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752223AbbEYJjA (ORCPT ); Mon, 25 May 2015 05:39:00 -0400 Received: from regular2.263xmail.com ([211.157.152.3]:56809 "EHLO regular2.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbbEYJi5 (ORCPT ); Mon, 25 May 2015 05:38:57 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: airlied@redhat.com X-SENDER-IP: 191.101.57.95 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <4bbc9ec35c215bbb1856f8797c4cba25> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <5562EDA8.1000609@rock-chips.com> Date: Mon, 25 May 2015 17:38:48 +0800 From: Yakir User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Paul Bolle CC: alsa-devel , dri-devel , linux-arm-kernel , Mark Brown , Takashi Iwai , Fabio Estevam , Russell King , Thierry Reding , Philipp Zabel , linux-kernel@vger.kernel.org, Inki Dae , Andy Yan , David Airlie , Greg Kroah-Hartman , Ajay Kumar , Dave Airlie Subject: Re: [RESEND PATCH v1 2/2] drm: bridge/dw_hdmi-i2s-audio: add audio driver References: <1432307631-7667-1-git-send-email-ykk@rock-chips.com> <1432307696-7806-1-git-send-email-ykk@rock-chips.com> <1432542247.27695.137.camel@x220> In-Reply-To: <1432542247.27695.137.camel@x220> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, 在 2015/5/25 16:24, Paul Bolle 写道: > Just a nit: a license mismatch. > > On Fri, 2015-05-22 at 10:14 -0500, Yakir Yang wrote: >> --- /dev/null >> +++ b/drivers/gpu/drm/bridge/dw_hdmi-i2s-audio.c >> + * This program is free software; you can redistribute it and/or modify >> + * it under the terms of the GNU General Public License version 2 as >> + * published by the Free Software Foundation. > This states the license is GPL v2. > >> +MODULE_LICENSE("GPL"); > And, according to include/linux/module.h, this states the license is GPL > v2 or later. So I think that either the comment at the top of this file > or the ident used in the MODULE_LICENSE() macro should change. Thanks for your catch, got it :-) Yakir Yang > > Paul Bolle > > > >