From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751892AbbEYO7o (ORCPT ); Mon, 25 May 2015 10:59:44 -0400 Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751475AbbEYO7l (ORCPT ); Mon, 25 May 2015 10:59:41 -0400 Message-ID: <556338DA.6000404@nod.at> Date: Mon, 25 May 2015 16:59:38 +0200 From: Richard Weinberger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: airlied@linux.ie CC: dri-devel@lists.freedesktop.org, "linux-kernel@vger.kernel.org" , "oleg@redhat.com" Subject: block_all_signals() usage in DRM Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! drivers/gpu/drm/drm_lock.c is the only remaining user of block_all_signals(): /* don't set the block all signals on the master process for now * really probably not the correct answer but lets us debug xkb * xserver for now */ if (!file_priv->is_master) { sigemptyset(&dev->sigmask); sigaddset(&dev->sigmask, SIGSTOP); sigaddset(&dev->sigmask, SIGTSTP); sigaddset(&dev->sigmask, SIGTTIN); sigaddset(&dev->sigmask, SIGTTOU); dev->sigdata.context = lock->context; dev->sigdata.lock = master->lock.hw_lock; block_all_signals(drm_notifier, dev, &dev->sigmask); } Is this functionality still in use/needed? Otherwise we could get rid of block_all_signals() and unpuzzle the signaling code a bit. :-) Thanks, //richard