From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Roger Quadros <rogerq@ti.com>, Andrew Bresticker <abrestic@chromium.org>
Cc: mathias.nyman@intel.com, Alan Stern <stern@rowland.harvard.edu>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] usb: xhci: cleanup xhci_hcd allocation
Date: Mon, 25 May 2015 18:05:27 +0300 [thread overview]
Message-ID: <55633A37.7040404@linux.intel.com> (raw)
In-Reply-To: <55520CA4.9040004@linux.intel.com>
>>>>
>>>> I've been testing add/remove HCD extensively and didn't observe any issues after applying
>>>> these 5 patches. Well there is one issue that comes up but it has nothing to do with xhci
>>>> not being allocated. It has more to do with command being queued after the HCD has gone away
>>>> and so getting stuck forever without timing out.
>>>
>>> I went through the codepaths and you're right, should work fine. My concern wasn't valid.
>>> This patchset doesn't even touch the order how primary and shared HCDs are created and added
>>> in the PCI case, only for the platform device case.
>>>
>>> I'll try it out and send forward once rc1 is out.
>>
>> did you get a chance to try this series?
>>
>
> Sorry, not yet, got delayed by other internal tasks.
> I'll try it out as soon as possible.
>
>
Ok, back to this, I'd like to get both this series and Andrew's xhci-tegra
support to 4.2
I did similar changes to xhci-tegra.c as Roger did to xhci-pci.c and xhci-plat.c,
but I can't test them and would need both your eyes on this to make sure it looks ok.
Both series are in a tegra_otg_merge topic branch in:
git://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git tegra_otg_merge
It contains Andrews full xhci tegra support series, but If I understood correctly only
patch 9/9 (maybe 8/9 as well?) will actually go through the xhci tree.
Patch 1/9 is not needed with Roger's changes anymre
The changes are in the last patch, here:
https://git.kernel.org/cgit/linux/kernel/git/mnyman/xhci.git/commit/?h=tegra_otg_merge
and would be squashed together with patch 9/9.
Thanks
Mathias
next prev parent reply other threads:[~2015-05-25 15:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 12:23 [PATCH 0/5] usb: xhci: fixes for OTG/DRD use Roger Quadros
2015-04-02 12:23 ` [PATCH 1/5] usb: xhci: cleanup xhci_hcd allocation Roger Quadros
2015-04-07 14:23 ` Mathias Nyman
2015-04-09 9:22 ` Roger Quadros
2015-04-13 12:48 ` Mathias Nyman
2015-04-14 9:21 ` Roger Quadros
2015-05-11 14:18 ` Roger Quadros
2015-05-12 14:22 ` Mathias Nyman
2015-05-25 15:05 ` Mathias Nyman [this message]
2015-05-26 16:31 ` Andrew Bresticker
2015-04-02 12:23 ` [PATCH 2/5] usb: xhci: plat: Create both HCDs before adding them Roger Quadros
2015-04-20 12:35 ` Mathias Nyman
2015-04-21 9:49 ` Roger Quadros
2015-04-21 7:11 ` Roger Quadros
2015-04-21 8:08 ` Maxime Ripard
2015-04-21 10:46 ` Roger Quadros
2015-04-22 13:46 ` Maxime Ripard
2015-04-02 12:23 ` [PATCH 3/5] usb: xhci: Allow usb_add/remove_hcd() to be called repeatedly Roger Quadros
2015-04-02 12:23 ` [PATCH 4/5] usb: xhci: fix xhci locking up during hcd remove Roger Quadros
2015-04-02 12:23 ` [PATCH 5/5] usb: xhci: Fix suspend/resume when used with OTG core Roger Quadros
2015-05-26 14:15 ` [PATCH] usb: host: xhci-pci: Fix NULL pointer dereference error Roger Quadros
2015-05-29 13:19 ` Mathias Nyman
2015-05-29 13:49 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55633A37.7040404@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=abrestic@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).