public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	xinhuix.pan@intel.com,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Cox <alan@linux.intel.com>
Subject: [PATCH 0/3] cdc-acm: fix incorrect runtime wakeup in acm_tty_write
Date: Tue, 26 May 2015 10:19:51 +0800	[thread overview]
Message-ID: <5563D847.106@linux.intel.com> (raw)

There is a scenario about cdc-acm utilization.Application opens

n_gsm tty and cdc-acm tty. cdc-acm tty connects to xhci device.

The application configures cdc-adm tty to n_gsm tty as ldisc tty.

     n_gsm=>cdc-acm=>xhci driver

acm_tty_write can be called from n_gsm driver by ldisc connection,

and from application when application opens cdc-acm tty directly.

acm_tty_write wakes up the device by calling usb_autopm_get_interface_async,

which calls pm_runtime_get. However, pm_runtime_get can't wake up

the device before returning as it's an async wake up. Then, acm_tty_write

might access the device when it is off.

The patchset fixes it by:

1) add a new function usb_autopm_get_interface_upgrade to deal with

above 2 requirements;

2) wake up device in n_gsm driver if n_gsm drivers calls cdc-acm driver;



                 reply	other threads:[~2015-05-26  2:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5563D847.106@linux.intel.com \
    --to=yanmin_zhang@linux.intel.com \
    --cc=alan@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xinhuix.pan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox