From: Ian Abbott <abbotti@mev.co.uk>
To: Matthew Needes <mneedes@gmail.com>,
H Hartley Sweeten <hsweeten@visionengravers.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes
Date: Tue, 26 May 2015 10:34:07 +0100 [thread overview]
Message-ID: <55643E0F.8090606@mev.co.uk> (raw)
In-Reply-To: <1432597281-15465-1-git-send-email-mneedes@gmail.com>
On 26/05/2015 00:41, Matthew Needes wrote:
> pcl812.c / pcl816.c (resend of earlier patch)
> Fixed indentation problems.
>
> Signed-off-by: Matthew Needes <mneedes@gmail.com>
>
> ---
> drivers/staging/comedi/drivers/pcl812.c | 2 +-
> drivers/staging/comedi/drivers/pcl816.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index 03a3fd6..7474ef9 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -1155,7 +1155,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>
> /* we need an IRQ to do DMA on channel 3 or 1 */
> if (dev->irq && board->has_dma)
> - pcl812_alloc_dma(dev, it->options[2]);
> + pcl812_alloc_dma(dev, it->options[2]);
>
> /* differential analog inputs? */
> switch (board->board_type) {
> diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
> index 1ccb2f1..781b321 100644
> --- a/drivers/staging/comedi/drivers/pcl816.c
> +++ b/drivers/staging/comedi/drivers/pcl816.c
> @@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
>
> /* check whole chanlist */
> for (i = 0, segpos = 0; i < chanlen; i++) {
> - if (chanlist[i] != chansegment[i % seglen]) {
> + if (chanlist[i] != chansegment[i % seglen]) {
> dev_dbg(dev->class_dev,
> "bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
> i, CR_CHAN(chansegment[i]),
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
prev parent reply other threads:[~2015-05-26 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-25 23:41 [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes Matthew Needes
2015-05-25 23:41 ` [PATCH 2/2] " Matthew Needes
2015-05-26 9:34 ` Ian Abbott
2015-05-26 9:34 ` Ian Abbott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55643E0F.8090606@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mneedes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox