* [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes
@ 2015-05-25 23:41 Matthew Needes
2015-05-25 23:41 ` [PATCH 2/2] " Matthew Needes
2015-05-26 9:34 ` [PATCH 1/2] " Ian Abbott
0 siblings, 2 replies; 4+ messages in thread
From: Matthew Needes @ 2015-05-25 23:41 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, devel,
linux-kernel
Cc: Matthew Needes
pcl812.c / pcl816.c (resend of earlier patch)
Fixed indentation problems.
Signed-off-by: Matthew Needes <mneedes@gmail.com>
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
drivers/staging/comedi/drivers/pcl816.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 03a3fd6..7474ef9 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -1155,7 +1155,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
/* we need an IRQ to do DMA on channel 3 or 1 */
if (dev->irq && board->has_dma)
- pcl812_alloc_dma(dev, it->options[2]);
+ pcl812_alloc_dma(dev, it->options[2]);
/* differential analog inputs? */
switch (board->board_type) {
diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
index 1ccb2f1..781b321 100644
--- a/drivers/staging/comedi/drivers/pcl816.c
+++ b/drivers/staging/comedi/drivers/pcl816.c
@@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
/* check whole chanlist */
for (i = 0, segpos = 0; i < chanlen; i++) {
- if (chanlist[i] != chansegment[i % seglen]) {
+ if (chanlist[i] != chansegment[i % seglen]) {
dev_dbg(dev->class_dev,
"bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
i, CR_CHAN(chansegment[i]),
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] staging: comedi/drivers/pcl.* coding style fixes
2015-05-25 23:41 [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes Matthew Needes
@ 2015-05-25 23:41 ` Matthew Needes
2015-05-26 9:34 ` Ian Abbott
2015-05-26 9:34 ` [PATCH 1/2] " Ian Abbott
1 sibling, 1 reply; 4+ messages in thread
From: Matthew Needes @ 2015-05-25 23:41 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten, Greg Kroah-Hartman, devel,
linux-kernel
Cc: Matthew Needes
pcl812.c (resend of earlier patch)
Fixed lines exceeding 80 columns, correcting some spelling in process
Signed-off-by: Matthew Needes <mneedes@gmail.com>
---
drivers/staging/comedi/drivers/pcl812.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
index 7474ef9..48f6cdf 100644
--- a/drivers/staging/comedi/drivers/pcl812.c
+++ b/drivers/staging/comedi/drivers/pcl812.c
@@ -507,11 +507,11 @@ static const struct pcl812_board boardtypes[] = {
struct pcl812_private {
struct comedi_isadma *dma;
- unsigned char range_correction; /* =1 we must add 1 to range number */
+ unsigned char range_correction; /* =1 we must add 1 to range number */
unsigned int last_ai_chanspec;
- unsigned char mode_reg_int; /* there is stored INT number for some card */
- unsigned int ai_poll_ptr; /* how many sampes transfer poll */
- unsigned int max_812_ai_mode0_rangewait; /* setling time for gain */
+ unsigned char mode_reg_int; /* stored INT number for some cards */
+ unsigned int ai_poll_ptr; /* how many samples transfer poll */
+ unsigned int max_812_ai_mode0_rangewait; /* settling time for gain */
unsigned int use_diff:1;
unsigned int use_mpc508:1;
unsigned int use_ext_trg:1;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes
2015-05-25 23:41 [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes Matthew Needes
2015-05-25 23:41 ` [PATCH 2/2] " Matthew Needes
@ 2015-05-26 9:34 ` Ian Abbott
1 sibling, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-05-26 9:34 UTC (permalink / raw)
To: Matthew Needes, H Hartley Sweeten, Greg Kroah-Hartman, devel,
linux-kernel
On 26/05/2015 00:41, Matthew Needes wrote:
> pcl812.c / pcl816.c (resend of earlier patch)
> Fixed indentation problems.
>
> Signed-off-by: Matthew Needes <mneedes@gmail.com>
>
> ---
> drivers/staging/comedi/drivers/pcl812.c | 2 +-
> drivers/staging/comedi/drivers/pcl816.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index 03a3fd6..7474ef9 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -1155,7 +1155,7 @@ static int pcl812_attach(struct comedi_device *dev, struct comedi_devconfig *it)
>
> /* we need an IRQ to do DMA on channel 3 or 1 */
> if (dev->irq && board->has_dma)
> - pcl812_alloc_dma(dev, it->options[2]);
> + pcl812_alloc_dma(dev, it->options[2]);
>
> /* differential analog inputs? */
> switch (board->board_type) {
> diff --git a/drivers/staging/comedi/drivers/pcl816.c b/drivers/staging/comedi/drivers/pcl816.c
> index 1ccb2f1..781b321 100644
> --- a/drivers/staging/comedi/drivers/pcl816.c
> +++ b/drivers/staging/comedi/drivers/pcl816.c
> @@ -323,7 +323,7 @@ static int check_channel_list(struct comedi_device *dev,
>
> /* check whole chanlist */
> for (i = 0, segpos = 0; i < chanlen; i++) {
> - if (chanlist[i] != chansegment[i % seglen]) {
> + if (chanlist[i] != chansegment[i % seglen]) {
> dev_dbg(dev->class_dev,
> "bad channel or range number! chanlist[%i]=%d,%d,%d and not %d,%d,%d!\n",
> i, CR_CHAN(chansegment[i]),
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2/2] staging: comedi/drivers/pcl.* coding style fixes
2015-05-25 23:41 ` [PATCH 2/2] " Matthew Needes
@ 2015-05-26 9:34 ` Ian Abbott
0 siblings, 0 replies; 4+ messages in thread
From: Ian Abbott @ 2015-05-26 9:34 UTC (permalink / raw)
To: Matthew Needes, H Hartley Sweeten, Greg Kroah-Hartman, devel,
linux-kernel
On 26/05/2015 00:41, Matthew Needes wrote:
> pcl812.c (resend of earlier patch)
> Fixed lines exceeding 80 columns, correcting some spelling in process
>
> Signed-off-by: Matthew Needes <mneedes@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcl812.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl812.c b/drivers/staging/comedi/drivers/pcl812.c
> index 7474ef9..48f6cdf 100644
> --- a/drivers/staging/comedi/drivers/pcl812.c
> +++ b/drivers/staging/comedi/drivers/pcl812.c
> @@ -507,11 +507,11 @@ static const struct pcl812_board boardtypes[] = {
>
> struct pcl812_private {
> struct comedi_isadma *dma;
> - unsigned char range_correction; /* =1 we must add 1 to range number */
> + unsigned char range_correction; /* =1 we must add 1 to range number */
> unsigned int last_ai_chanspec;
> - unsigned char mode_reg_int; /* there is stored INT number for some card */
> - unsigned int ai_poll_ptr; /* how many sampes transfer poll */
> - unsigned int max_812_ai_mode0_rangewait; /* setling time for gain */
> + unsigned char mode_reg_int; /* stored INT number for some cards */
> + unsigned int ai_poll_ptr; /* how many samples transfer poll */
> + unsigned int max_812_ai_mode0_rangewait; /* settling time for gain */
> unsigned int use_diff:1;
> unsigned int use_mpc508:1;
> unsigned int use_ext_trg:1;
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-26 13:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-25 23:41 [PATCH 1/2] staging: comedi/drivers/pcl.* coding style fixes Matthew Needes
2015-05-25 23:41 ` [PATCH 2/2] " Matthew Needes
2015-05-26 9:34 ` Ian Abbott
2015-05-26 9:34 ` [PATCH 1/2] " Ian Abbott
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox