Re: [PATCH] char:ipmi - Change 1 to true for bool type variables during initialization.

[Corey Minyard <minyard@acm.org>]

Thanks, queued for the next kernel release.

-corey

On 05/25/2015 02:24 PM, Shailendra Verma wrote:
> Signed-off-by: Shailendra Verma <shailendra.capricorn@gmail.com>
> ---
>  drivers/char/ipmi/ipmi_si_intf.c |    8 ++++----
>  drivers/char/ipmi/ipmi_ssif.c    |    4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 8a45e92..e8b406b 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -1283,14 +1283,14 @@ static int smi_num; /* Used to sequence the SMIs */
>  #define DEFAULT_REGSIZE		1
>  
>  #ifdef CONFIG_ACPI
> -static bool          si_tryacpi = 1;
> +static bool          si_tryacpi = true;
>  #endif
>  #ifdef CONFIG_DMI
> -static bool          si_trydmi = 1;
> +static bool          si_trydmi = true;
>  #endif
> -static bool          si_tryplatform = 1;
> +static bool          si_tryplatform = true;
>  #ifdef CONFIG_PCI
> -static bool          si_trypci = 1;
> +static bool          si_trypci = true;
>  #endif
>  static bool          si_trydefaults = IS_ENABLED(CONFIG_IPMI_SI_PROBE_DEFAULTS);
>  static char          *si_type[SI_MAX_PARMS];
> diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c
> index 207689c..428a5fa 100644
> --- a/drivers/char/ipmi/ipmi_ssif.c
> +++ b/drivers/char/ipmi/ipmi_ssif.c
> @@ -1154,11 +1154,11 @@ static int use_thread;
>  module_param(use_thread, int, 0);
>  MODULE_PARM_DESC(use_thread, "Use the thread interface.");
>  
> -static bool ssif_tryacpi = 1;
> +static bool ssif_tryacpi = true;
>  module_param_named(tryacpi, ssif_tryacpi, bool, 0);
>  MODULE_PARM_DESC(tryacpi, "Setting this to zero will disable the default scan of the interfaces identified via ACPI");
>  
> -static bool ssif_trydmi = 1;
> +static bool ssif_trydmi = true;
>  module_param_named(trydmi, ssif_trydmi, bool, 0);
>  MODULE_PARM_DESC(trydmi, "Setting this to zero will disable the default scan of the interfaces identified via DMI (SMBIOS)");
>