From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751738AbbEZO2b (ORCPT ); Tue, 26 May 2015 10:28:31 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:36551 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbbEZO21 (ORCPT ); Tue, 26 May 2015 10:28:27 -0400 Message-ID: <55648309.9020400@acm.org> Date: Tue, 26 May 2015 09:28:25 -0500 From: Corey Minyard Reply-To: minyard@acm.org User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Shailendra Verma , openipmi-developer@lists.sourceforge.net CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH] char:ipmi - Change 1 to true for bool type variables during initialization. References: <1432581897-4850-1-git-send-email-shailendra.capricorn@gmail.com> In-Reply-To: <1432581897-4850-1-git-send-email-shailendra.capricorn@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, queued for the next kernel release. -corey On 05/25/2015 02:24 PM, Shailendra Verma wrote: > Signed-off-by: Shailendra Verma > --- > drivers/char/ipmi/ipmi_si_intf.c | 8 ++++---- > drivers/char/ipmi/ipmi_ssif.c | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c > index 8a45e92..e8b406b 100644 > --- a/drivers/char/ipmi/ipmi_si_intf.c > +++ b/drivers/char/ipmi/ipmi_si_intf.c > @@ -1283,14 +1283,14 @@ static int smi_num; /* Used to sequence the SMIs */ > #define DEFAULT_REGSIZE 1 > > #ifdef CONFIG_ACPI > -static bool si_tryacpi = 1; > +static bool si_tryacpi = true; > #endif > #ifdef CONFIG_DMI > -static bool si_trydmi = 1; > +static bool si_trydmi = true; > #endif > -static bool si_tryplatform = 1; > +static bool si_tryplatform = true; > #ifdef CONFIG_PCI > -static bool si_trypci = 1; > +static bool si_trypci = true; > #endif > static bool si_trydefaults = IS_ENABLED(CONFIG_IPMI_SI_PROBE_DEFAULTS); > static char *si_type[SI_MAX_PARMS]; > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index 207689c..428a5fa 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -1154,11 +1154,11 @@ static int use_thread; > module_param(use_thread, int, 0); > MODULE_PARM_DESC(use_thread, "Use the thread interface."); > > -static bool ssif_tryacpi = 1; > +static bool ssif_tryacpi = true; > module_param_named(tryacpi, ssif_tryacpi, bool, 0); > MODULE_PARM_DESC(tryacpi, "Setting this to zero will disable the default scan of the interfaces identified via ACPI"); > > -static bool ssif_trydmi = 1; > +static bool ssif_trydmi = true; > module_param_named(trydmi, ssif_trydmi, bool, 0); > MODULE_PARM_DESC(trydmi, "Setting this to zero will disable the default scan of the interfaces identified via DMI (SMBIOS)"); >