From: Edward Cree <ecree@solarflare.com>
To: Bandan Das <bsd@redhat.com>
Cc: Xiao Guangrong <guangrong.xiao@linux.intel.com>,
<pbonzini@redhat.com>, <gleb@kernel.org>, <mtosatti@redhat.com>,
<kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] KVM: MMU: fix SMAP virtualization
Date: Tue, 26 May 2015 15:45:07 +0100 [thread overview]
Message-ID: <556486F3.5020007@solarflare.com> (raw)
In-Reply-To: <jpgzj4w9nj7.fsf@redhat.com>
>> This breaks older compilers that can't initialize anon structures.
>
> How old ? Even gcc 3.1 says you can use unnamed struct/union fields and
> 3.2 is the minimum version required to compile the kernel as mentioned
> in the README.
>
> We could simply just name the structure, but I doubt this is the
> only place in the kernel code where it's being used this way :)
This appears to be GCC bug #10676, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676>
Says it was fixed in 4.6, but I believe the kernel supports GCCs much older
than that (back to 3.2). I personally hit it on 4.4.7, the version shipped
with RHEL6.6.
So I think the kernel code has to change, probably by naming the structure.
next prev parent reply other threads:[~2015-05-26 14:45 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-11 14:55 [PATCH 1/2] KVM: MMU: fix SMAP virtualization Xiao Guangrong
2015-05-11 14:55 ` [PATCH 2/2] KVM: MMU: document smap_andnot_wp Xiao Guangrong
2015-05-11 15:16 ` Paolo Bonzini
2015-05-22 20:43 ` [PATCH 1/2] KVM: MMU: fix SMAP virtualization Boris Ostrovsky
2015-05-22 23:54 ` Bandan Das
2015-05-23 0:42 ` Boris Ostrovsky
2015-05-26 14:45 ` Edward Cree [this message]
2015-05-26 14:48 ` Paolo Bonzini
2015-05-27 2:53 ` Xiao Guangrong
2015-06-09 5:14 ` Vinson Lee
2015-06-12 12:11 ` Luis Henriques
2015-06-10 18:02 ` Davidlohr Bueso
2015-06-10 18:08 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=556486F3.5020007@solarflare.com \
--to=ecree@solarflare.com \
--cc=bsd@redhat.com \
--cc=gleb@kernel.org \
--cc=guangrong.xiao@linux.intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox