From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751563AbbEZRBG (ORCPT ); Tue, 26 May 2015 13:01:06 -0400 Received: from sender1.zohomail.com ([74.201.84.157]:24419 "EHLO sender1.zohomail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbbEZRBE (ORCPT ); Tue, 26 May 2015 13:01:04 -0400 Message-ID: <5564A6A9.3000607@kerneldev.net> Date: Tue, 26 May 2015 12:00:25 -0500 From: Jaime Arrocha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.4.0 MIME-Version: 1.0 To: Dan Carpenter , Jaime Arrocha CC: gregkh@linuxfoundation.org, jonathankim@gctsemi.com, deanahn@gctsemi.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] staging: gdm724x: Remove test for host endian References: <20150526152944.GA23178@localhost.localdomain> <20150526155953.GK11588@mwanda> In-Reply-To: <20150526155953.GK11588@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-ZohoMail: Ss SS_10 UW UB CHF_INT_SMD_EXT SGR4_1_08055_0 X-ZohoMail-Owner: <5564A6A9.3000607@kerneldev.net>+zmo_0_ X-ZohoMail-Sender: 71.123.203.27 X-Zoho-Virus-Status: 2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/2015 10:59 AM, Dan Carpenter wrote: > On Tue, May 26, 2015 at 10:29:44AM -0500, Jaime Arrocha wrote: >> This is the first patch of two. Both patches perform a small clean up >> done to the section for host endian test. Instead of handling endianness >> internally, kernel functions were added for use. > >> The second patch depends on the first one, it is just a small piece >> that is no longer needed. > > This kind of dependencies are built in the the name patch 1/2 and 2/2. > We don't want this kind of meta commentary in the permanent changelog. > If it were needed then it would go under the --- cut off line. > > And anyway, fold patch 1 & 2 together into one patch. Do "one thing" > per patch instead of half a thing per patch. > Thanks for the feedback. I'll do the corrections needed. >> >> Signed-off-by: Jaime Arrocha >> --- > > <--- meta commentary goes here. > >> drivers/staging/gdm724x/gdm_endian.c | 52 +++++++++++++++------------------- >> 1 file changed, 23 insertions(+), 29 deletions(-) >> >> diff --git a/drivers/staging/gdm724x/gdm_endian.c b/drivers/staging/gdm724x/gdm_endian.c >> index f6cc90a..609a433 100644 >> --- a/drivers/staging/gdm724x/gdm_endian.c >> +++ b/drivers/staging/gdm724x/gdm_endian.c >> @@ -11,57 +11,51 @@ >> * GNU General Public License for more details. >> */ >> >> -#include > > Is this related to endianness? > This was needed because the original code uses memcpy() inside gdm_set_endian() to test for host endianness. >> +#include >> +#ifdef __LITTLE_ENDIAN >> +#include >> +#else >> +#include >> +#endif > > Why do we need this? Also the spacing is wrong. > Yes,this needs to go. It was from an old change where I was obtaining host endianness. It will be replaced by linux/byteorder/generic.h >> u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x) >> { >> - if (ed->dev_ed == ed->host_ed) >> - return x; >> - >> - return Endian16_Swap(x); >> + if (ed->dev_ed == ENDIANNESS_LITTLE) >> + return __cpu_to_le16(x); >> + else >> + return __cpu_to_be16(x); > > Use cpu_to_le16() no underscore versions everywhere. The other is for > code which is shared with usespace. > > regards, > dan carpenter > >