Re: [PATCH v4 06/35] staging: rtl8192e: Replace memcmp() with ether_addr_equal_unaligned()

Mateusz Kulikowski
2015-05-26T19:24:45Z

On 25.05.2015 16:03, Dan Carpenter wrote:
> On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote:
>> Use dedicated macro to compare ethernet addresses in probe_rq_parse().
>>
>> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
>> ---
>> drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
>> index 8689b16..65297a0 100644
>> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
>> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
>> @@ -1853,7 +1853,8 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb,
>> return -1; /* corrupted */
>>
>> bssid_match =
>> - (memcmp(header->addr3, ieee->current_network.bssid, ETH_ALEN) != 0) &&
>> + (!ether_addr_equal_unaligned(header->addr3,
>> + ieee->current_network.bssid)) &&
>
> Isn't this aligned?

Yes, this time it is - my bad sorry - I missed this one.

Regards,
Mateusz