Re: [PATCH v4 02/35] staging: rtl8192e: Declare ethernet addresses as __aligned(2)

Joe Perches
2015-05-26T21:04:20Z

On Tue, 2015-05-26 at 22:25 +0200, Mateusz Kulikowski wrote:
> On 25.05.2015 15:53, Dan Carpenter wrote:
> >> diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
[]
> >> + static const u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {
> >> + 0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01
> >> + };
> >
> > What's up with the whacky indenting?
>
> It was proposal from Joe;

Not quite. I suggested:

static const u8 bMac_Tmp_Addr[ETH_ALEN] __aligned(2) = {
0x00, 0xe0, 0x4c, 0x00, 0x00, 0x01
};

> perhaps breaking 80-column line would be even better in that case
> (for sure will be once I remove __aligned)