Re: [PATCH v4 06/35] staging: rtl8192e: Replace memcmp() with ether_addr_equal_unaligned()

Dan Carpenter
2015-05-25T14:03:54Z

On Thu, May 21, 2015 at 05:53:19PM +0200, Mateusz Kulikowski wrote:
> Use dedicated macro to compare ethernet addresses in probe_rq_parse().
>
> Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 8689b16..65297a0 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -1853,7 +1853,8 @@ static short probe_rq_parse(struct rtllib_device *ieee, struct sk_buff *skb,
> return -1; /* corrupted */
>
> bssid_match =
> - (memcmp(header->addr3, ieee->current_network.bssid, ETH_ALEN) != 0) &&
> + (!ether_addr_equal_unaligned(header->addr3,
> + ieee->current_network.bssid)) &&

Isn't this aligned?

Joe, I really dread these checkpatch.pl patches. It's the kind of thing
I hate more as time goes on and not less...

regards,
dan carpenter