From: Stephen Boyd <sboyd@codeaurora.org>
To: Ankit Gupta <ankgupta@codeaurora.org>
Cc: gavidov@codeaurora.org, sdharia@codeaurora.org,
ivan.ivanov@linaro.org, svarbanov@mm-sol.com,
rostedt@goodmis.org, linux-arm-msm@vger.kernel.org,
gregkh@linuxfoundation.org, collinsd@codeaurora.org,
osvaldob@codeaurora.org, linux-kernel@vger.kernel.org,
mlocke@codeaurora.org, galak@codeaurora.org,
agross@codeaurora.org
Subject: Re: [PATCH] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver
Date: Tue, 26 May 2015 16:44:45 -0700 [thread overview]
Message-ID: <5565056D.4050200@codeaurora.org> (raw)
In-Reply-To: <1432683555-4644-1-git-send-email-ankgupta@codeaurora.org>
On 05/26/2015 04:39 PM, Ankit Gupta wrote:
> The spmi-pmic-arb is also an interrupt controller. It gets a
> single aggregate irq and disseminates it to individual
> pmic-peripheral drivers. Each pmic-peripheral has a unique apid
> number, and can have multiple interrupt capable functions.
> The registered apid range shows the lowest and highest apid
> numbers of pmic-peripheral drivers which request irqs. Pid is
> the base address of that peripheral. For performance measurement,
> tracepoints are added at the beginning of the aggregate irq and
> at the end of the individual pmic-peripheral irqs.
>
> Following is a list showing the new tracepoint events:
>
> spmi_pmic_arb_aggregate_irq_start: aggregate irq number and registered
> apid range.
>
> spmi_pmic_arb_apid_irq_end: apid, irq, func_num, sid and pid.
>
> SPMI Interrupts tracepoints can be enabled like:
>
> echo 1 >/sys/kernel/debug/tracing/events/spmi-pmic-arb/enable
>
> and will dump messages that can be viewed in
> /sys/kernel/debug/tracing/trace that look like:
> ... spmi_pmic_arb_aggregate_irq_start: irq=150 registered apid range=(3,189)
> ... spmi_pmic_arb_apid_irq_end: apid=3 irq=1 func_num=0 sid=0 pid=0x8
>
> Suggested-by: Sagar Dharia <sdharia@codeaurora.org>
> Signed-off-by: Gilad Avidov <gavidov@codeaurora.org>
> Signed-off-by: Ankit Gupta <ankgupta@codeaurora.org>
> ---
How is this any better than irq tracepoints that we already have for
generic irqs?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-05-26 23:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 23:39 [PATCH] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver Ankit Gupta
2015-05-26 23:44 ` Stephen Boyd [this message]
2015-05-27 15:06 ` Ankit Gupta
2015-05-27 20:06 ` Stephen Boyd
2015-05-28 23:02 ` Gilad Avidov
2015-05-29 1:15 ` Stephen Boyd
2015-05-29 19:56 ` Gilad Avidov
2015-05-26 23:58 ` Steven Rostedt
2015-05-27 15:09 ` Ankit Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5565056D.4050200@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=ankgupta@codeaurora.org \
--cc=collinsd@codeaurora.org \
--cc=galak@codeaurora.org \
--cc=gavidov@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ivan.ivanov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mlocke@codeaurora.org \
--cc=osvaldob@codeaurora.org \
--cc=rostedt@goodmis.org \
--cc=sdharia@codeaurora.org \
--cc=svarbanov@mm-sol.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox