From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751991AbbEZXou (ORCPT ); Tue, 26 May 2015 19:44:50 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:38682 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751922AbbEZXos (ORCPT ); Tue, 26 May 2015 19:44:48 -0400 Message-ID: <5565056D.4050200@codeaurora.org> Date: Tue, 26 May 2015 16:44:45 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Ankit Gupta CC: gavidov@codeaurora.org, sdharia@codeaurora.org, ivan.ivanov@linaro.org, svarbanov@mm-sol.com, rostedt@goodmis.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, collinsd@codeaurora.org, osvaldob@codeaurora.org, linux-kernel@vger.kernel.org, mlocke@codeaurora.org, galak@codeaurora.org, agross@codeaurora.org Subject: Re: [PATCH] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver References: <1432683555-4644-1-git-send-email-ankgupta@codeaurora.org> In-Reply-To: <1432683555-4644-1-git-send-email-ankgupta@codeaurora.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/2015 04:39 PM, Ankit Gupta wrote: > The spmi-pmic-arb is also an interrupt controller. It gets a > single aggregate irq and disseminates it to individual > pmic-peripheral drivers. Each pmic-peripheral has a unique apid > number, and can have multiple interrupt capable functions. > The registered apid range shows the lowest and highest apid > numbers of pmic-peripheral drivers which request irqs. Pid is > the base address of that peripheral. For performance measurement, > tracepoints are added at the beginning of the aggregate irq and > at the end of the individual pmic-peripheral irqs. > > Following is a list showing the new tracepoint events: > > spmi_pmic_arb_aggregate_irq_start: aggregate irq number and registered > apid range. > > spmi_pmic_arb_apid_irq_end: apid, irq, func_num, sid and pid. > > SPMI Interrupts tracepoints can be enabled like: > > echo 1 >/sys/kernel/debug/tracing/events/spmi-pmic-arb/enable > > and will dump messages that can be viewed in > /sys/kernel/debug/tracing/trace that look like: > ... spmi_pmic_arb_aggregate_irq_start: irq=150 registered apid range=(3,189) > ... spmi_pmic_arb_apid_irq_end: apid=3 irq=1 func_num=0 sid=0 pid=0x8 > > Suggested-by: Sagar Dharia > Signed-off-by: Gilad Avidov > Signed-off-by: Ankit Gupta > --- How is this any better than irq tracepoints that we already have for generic irqs? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project