Re: [PATCH v2 v3.18-rc4 2/4] drm: prime: Document gem_prime_mmap

Rob Clark
2014-11-12T14:42:41Z

On Wed, Nov 12, 2014 at 6:38 AM, Daniel Thompson
<daniel.thompson@linaro.org> wrote:
> gem_prime_map is not currently described in the DRM manual, lets document
> it.
>
> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>

Reviewed-by: Rob Clark <robdclark@gmail.com>

> ---
> drivers/gpu/drm/drm_prime.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_prime.c b/drivers/gpu/drm/drm_prime.c
> index 8467b17c8053..5d00c8726133 100644
> --- a/drivers/gpu/drm/drm_prime.c
> +++ b/drivers/gpu/drm/drm_prime.c
> @@ -309,7 +309,7 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
> * Drivers can implement @gem_prime_export and @gem_prime_import in terms of
> * simpler APIs by using the helper functions @drm_gem_prime_export and
> * @drm_gem_prime_import. These functions implement dma-buf support in terms of
> - * five lower-level driver callbacks:
> + * six lower-level driver callbacks:
> *
> * Export callbacks:
> *
> @@ -321,6 +321,8 @@ static const struct dma_buf_ops drm_gem_prime_dmabuf_ops = {
> *
> * - @gem_prime_vunmap: vunmap a buffer exported by your driver
> *
> + * - @gem_prime_mmap (optional): mmap a buffer exported by your driver
> + *
> * Import callback:
> *
> * - @gem_prime_import_sg_table (import): produce a GEM object from another
> --
> 1.9.3
>