Re: [PATCH v2 v3.18-rc4 1/4] drm: prime: Honour O_RDWR during prime-handle-to-fd

Daniel Thompson
2015-05-27T07:48:51Z

On 27/05/15 04:15, Damian Hobson-Garcia wrote:
> Hello,
>> On Wed, Nov 12, 2014 at 6:38 AM, Daniel Thompson <daniel.thompson@linaro.org> wrote:
>>> Currently DRM_IOCTL_PRIME_HANDLE_TO_FD rejects all flags except
>>> (DRM|O)_CLOEXEC making it hard for the userspace to generate a file
>>> descriptor that can be used by mmap().
>>>
>>> It is easy to relax the restriction and allow read/write permissions.
>>> This should be safe because the flags are seldom touched by drm; mostly
>>> they are passed verbatim to dma_buf calls.
>>>
>>> Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
>>
>> Reviewed-by: Rob Clark <robdclark@gmail.com>
>
> It's a little bit old by now, but I'm wondering if someone call tell me
> whether this patch is likely to be merged sometime, or has it been
> (should it be?) abandoned.

For me, this code remains useful and it would be good to merge it.

I accidentally removed the whole patchset from my
"keep-resending-these-patches" when patch 3 went upstream... I'll rebase
this when I get a chance.

Daniel.

PS
Damn it all..., Rob may (or may not) remember my saying I had trouble
getting the DRM GFX code to come up on my Android/IFC6410 port. Losing
track of this patch would certainly explain it!