From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752398AbbE0DbG (ORCPT ); Tue, 26 May 2015 23:31:06 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:31513 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752034AbbE0DbD (ORCPT ); Tue, 26 May 2015 23:31:03 -0400 Message-ID: <55653A6C.3060707@oracle.com> Date: Tue, 26 May 2015 20:30:52 -0700 From: Mike Kravetz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Andrew Morton CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Naoya Horiguchi , Davidlohr Bueso , David Rientjes , Luiz Capitulino Subject: Re: [PATCH] mm/hugetlb: document the reserve map/region tracking routines References: <1432675630-7623-1-git-send-email-mike.kravetz@oracle.com> <20150526160900.0c0868b73e40995d3d65c616@linux-foundation.org> In-Reply-To: <20150526160900.0c0868b73e40995d3d65c616@linux-foundation.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/26/2015 04:09 PM, Andrew Morton wrote: > On Tue, 26 May 2015 14:27:10 -0700 Mike Kravetz wrote: > >> This is a documentation only patch and does not modify any code. >> Descriptions of the routines used for reserve map/region tracking >> are added. > > Confused. This adds comments which are similar to the ones which were > added by > mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v2.patch > and > mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v2.patch. > But the comments are a bit different. And this patch madly conflicts > with the two abovementioned patches. > > Maybe the thing to do is to start again, with a three-patch series: > > mm-hugetlb-document-the-reserve-map-region-tracking-routines.patch > mm-hugetlb-compute-return-the-number-of-regions-added-by-region_add-v3.patch > mm-hugetlb-handle-races-in-alloc_huge_page-and-hugetlb_reserve_pages-v3.patch > > while resolving the differences in the new code comments? > Sorry for the confusion. Naoya and Davidlohr suggested changes to the documentation and code. One suggestion was to create a separate documentation only patch. I will create a new series as you suggest above. -- Mike Kravetz