From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752212AbbE0Dnz (ORCPT ); Tue, 26 May 2015 23:43:55 -0400 Received: from mga11.intel.com ([192.55.52.93]:54425 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751194AbbE0Dnw (ORCPT ); Tue, 26 May 2015 23:43:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,502,1427785200"; d="scan'208";a="700726644" Message-ID: <55653D75.1050808@linux.intel.com> Date: Wed, 27 May 2015 11:43:49 +0800 From: "Zhang, Yanmin" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Greg KH CC: linux-kernel@vger.kernel.org, xinhuix.pan@intel.com, alan@linux.intel.com Subject: Re: [PATCH V2 3/3] n_gsm: wake up ldisc tty before using it References: <556530D9.5060506@linux.intel.com> <20150527030212.GB9124@kroah.com> In-Reply-To: <20150527030212.GB9124@kroah.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015/5/27 11:02, Greg KH wrote: > On Wed, May 27, 2015 at 10:50:01AM +0800, Zhang, Yanmin wrote: >> Wake up ldisc device before calling its driver to access the device. >> >> Signed-off-by: Zhang Yanmin >> >> --- >> >> drivers/tty/n_gsm.c | 40 +++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 39 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c >> index 2c34c32..40671fa 100644 >> --- a/drivers/tty/n_gsm.c >> +++ b/drivers/tty/n_gsm.c >> @@ -62,6 +62,7 @@ >> #include >> #include >> #include >> +#include >> >> static int debug; >> module_param(debug, int, 0600); >> @@ -555,6 +556,27 @@ static int gsm_stuff_frame(const u8 *input, u8 *output, int len) >> return olen; >> } >> >> +static int pm_runtime_get_sync_tty(struct tty_struct *tty) >> +{ >> + int ret = 0; >> + >> + /*Wakeup parent as tty itself doesn't enable runtime*/ > No spaces in your comment? I will add it. > > Anyway, this is corrupted and can't be applied, please fix up your email > client and try it again... I check the patch by scripts/checkpatch.pl and everything seems good. I use Thunderbird 31.7.0, the latest. It auto updates to the latest version. Perhaps some new config options changed something. It seems email client converts some tab to space automatically. Yanmin